Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse workspace]Support cleanup property for integration runtime resource of Synapse workspace. #15279

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

jackmagic313
Copy link
Contributor

@jackmagic313 jackmagic313 commented Jul 21, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@jackmagic313 jackmagic313 requested a review from idear1203 as a code owner July 21, 2021 02:11
@openapi-workflow-bot
Copy link

Hi, @jackmagic313 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 21, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: synapse/common/v1/privateEndpointConnection.json#L326
    R4009 - RequiredReadOnlySystemData The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'IpFirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/firewallRule.json#L203
    R4009 - RequiredReadOnlySystemData The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L85
    R4009 - RequiredReadOnlySystemData The response of operation:'Keys_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/keys.json#L75
    R4009 - RequiredReadOnlySystemData The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/library.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json#L46
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L75
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkHubPrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/privateLinkResources.json#L175
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateLinkHubs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json#L86
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L25
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMetadataSyncConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L520
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolGeoBackupPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L851
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolDataWarehouseUserActivities_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L921
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolReplicationLinks_GetByName' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1172
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMaintenanceWindows_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1233
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolMaintenanceWindowOptions_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1356
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolTransparentDataEncryptions_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1414
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L1619
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolSensitivityLabels_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2290
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolConnectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L2739
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolSecurityAlertPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3130
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolVulnerabilityAssessmentRuleBaselines_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3449
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3535
    R4009 - RequiredReadOnlySystemData The response of operation:'ExtendedSqlPoolBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L3747
    R4009 - RequiredReadOnlySystemData The response of operation:'DataMaskingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4007
    R4009 - RequiredReadOnlySystemData The response of operation:'DataMaskingRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4148
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolSchemas_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4323
    R4009 - RequiredReadOnlySystemData The response of operation:'SqlPoolTables_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L4380
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"The schema 'KekIdentityProperties-useSystemAssignedIdentity' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json#/components/schemas/KekIdentityProperties-useSystemAssignedIdentity"
    💬 AutorestCore/Exception "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PreCheck/DuplicateSchema "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1325",
    properties.id.description: "identifier" =>,
    properties.id.readOnly: true =>,
    properties.properties.description: "Properties of private endpoint connection for private link hub" =>,
    properties.properties.x-ms-client-flatten: true => "
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'"
    ⚠️ PreCheck/DuplicateSchema "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:872" "
    ⚠️ PreCheck/DuplicateSchema "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:876" "
    ⚠️ PreCheck/DuplicateSchema "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.$ref: undefined => "#/components/schemas/schemas:1175",
    properties.id.description: "identifier" =>,
    properties.id.readOnly: true =>,
    properties.properties.description: "Properties of private endpoint connection for private link hub" =>,
    properties.properties.x-ms-client-flatten: true => "
    ⚠️ PreCheck/PropertyRedeclarationWarning "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Deduplicating schema name: 'SecurityAlertPolicyName' -> 'SecurityAlertPolicyNameAutoGenerated'"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Deduplicating schema name: 'PrivateEndpointConnectionForPrivateLinkHubBasic' -> 'PrivateEndpointConnectionForPrivateLinkHubBasicAutoGenerated'"
    ⚠️ PreNamer/DeduplicateName "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"Deduplicating schema name: 'CloudError' -> 'CloudErrorAutoGenerated'"
    💬 AutorestCore/Exception "readme":"synapse/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2019-06-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 21, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.0.0
    ️✔️azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v56.3.0
    ️✔️azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v56.3.0
    ️✔️azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v56.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 39c458f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      cmderr	[npmPack] created ./dist/arm-synapse.js in 1.3s
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 39c458f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-08-27 09:55:49 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-08-27 09:55:49 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-08-27 09:55:49 INFO autorest --version=3.4.5 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[generate.py]   Error: $ref to original location 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#/components/schemas/SubResource' is not found in the new refs collection
      cmderr	[generate.py] 2021-08-27 09:56:21 ERROR [GENERATE] Autorest fail
      cmderr	[generate.py] 2021-08-27 09:57:13 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-08-27 09:57:15 DEBUG Got artifact_id: azure-resourcemanager-synapse
      cmderr	[Inst] 2021-08-27 09:57:15 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-08-27 09:57:15 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-08-27 09:57:15 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-08-27 09:57:15 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15279/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.2.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 39c458f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model SqlPool has a new parameter source_database_deletion_date
      info	[Changelog]   - Model IntegrationRuntimeVNetProperties has a new parameter subnet_id
      info	[Changelog]   - Model SqlPoolPatchInfo has a new parameter source_database_deletion_date
      info	[Changelog]   - Model IntegrationRuntimeDataFlowProperties has a new parameter cleanup
      info	[Changelog]   - Model DataLakeStorageAccountDetails has a new parameter create_managed_private_endpoint
      info	[Changelog]   - Model DataLakeStorageAccountDetails has a new parameter resource_id
      info	[Changelog]   - Model Workspace has a new parameter settings
      info	[Changelog]   - Model Workspace has a new parameter azure_ad_only_authentication
      info	[Changelog]   - Model Workspace has a new parameter csp_workspace_admin_properties
      info	[Changelog]   - Model CustomerManagedKeyDetails has a new parameter kek_identity
      info	[Changelog]   - Model ManagedIdentity has a new parameter user_assigned_identities
      info	[Changelog]   - Added operation PrivateEndpointConnectionsPrivateLinkHubOperations.get
      info	[Changelog]   - Added operation IntegrationRuntimesOperations.list_outbound_network_dependencies_endpoints
      info	[Changelog]   - Added operation group AzureADOnlyAuthenticationsOperations
      info	[Changelog]   - Added operation group SparkConfigurationsOperations
      info	[Changelog]   - Added operation group SparkConfigurationOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 39c458f. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️synapse/mgmt/2021-03-01/synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU`
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsResponder(*http.Response) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
      info	[Changelog]
    • ️✔️synapse/mgmt/2020-12-01/synapse [View full logs
      Only show 30 items here, please refer to log for details.
      info	[Changelog] - New function `NewLibraryClientWithBaseURI(string, string) LibraryClient`
      info	[Changelog] - New function `LibraryListResponse.IsEmpty() bool`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage`
      info	[Changelog] - New function `LibraryResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `LibraryListResponsePage.Response() LibraryListResponse`
      info	[Changelog] - New function `LibraryClient.Get(context.Context, string, string, string) (LibraryResource, error)`
      info	[Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource`
      info	[Changelog] - New function `LibraryClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `NewLibrariesClient(string) LibrariesClient`
      info	[Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator`
      info	[Changelog] - New function `LibraryListResponseIterator.NotDone() bool`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `LibraryClient.GetResponder(*http.Response) (LibraryResource, error)`
      info	[Changelog] - New function `LibrariesClient.ListByWorkspaceResponder(*http.Response) (LibraryListResponse, error)`
      info	[Changelog] - New function `*LibraryListResponsePage.Next() error`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New struct `LibrariesClient`
      info	[Changelog] - New struct `LibraryClient`
      info	[Changelog] - New struct `LibraryListResponse`
      info	[Changelog] - New struct `LibraryListResponseIterator`
      info	[Changelog] - New struct `LibraryListResponsePage`
      info	[Changelog] - New struct `LibraryResource`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 55 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/2021-06-01-preview/synapse [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logsBreaking Change Detected
      Only show 30 items here, please refer to log for details.
      info	[Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdate`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateList`
      info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties`
      info	[Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient`
      info	[Changelog] - New struct `SQLPoolMaintenanceWindowsClient`
      info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
      info	[Changelog] - New struct `SensitivityLabelUpdate`
      info	[Changelog] - New struct `SensitivityLabelUpdateList`
      info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
      info	[Changelog] - New field `ClientID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `ClientSecret` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
      info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 122 additive change(s).
      info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 39c458f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️synapse [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @jackmagic313
    Copy link
    Contributor Author

    @idear1203 could you help to take a look when you have time? The related PR on Data Factory service is: #15276

    @idear1203 idear1203 self-requested a review July 28, 2021 02:43
    @idear1203
    Copy link
    Contributor

    Please make change to the latest preview API version here

    cc @wonner

    @jackmagic313
    Copy link
    Contributor Author

    Please make change to the latest preview API version here

    cc @wonner

    This PR will cover latest API version as well since the resource contract is referred by specs of all API versions. For example,

    "$ref": "../../../../resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#/definitions/IntegrationRuntimeResource"

    @idear1203
    Copy link
    Contributor

    Sorry for the misleading. Please update the Swagger spec here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/integrationRuntime.json#L1394 . In the next management SDK release, we will use this Swagger spec as input file.

    @ghost
    Copy link

    ghost commented Aug 22, 2021

    Hi, @jackmagic313. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants