Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Microsoft.AppConfiguration 2021-03-01-preview API version. #13490

Merged
merged 6 commits into from
Apr 8, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"api-version": "2021-03-01-preview",
"checkNameAvailabilityParameters": {
"name": "contoso",
"type": "Microsoft.AppConfiguration/configurationStores"
}
},
"responses": {
"200": {
"body": {
"nameAvailable": true,
"message": "The specified name is available.",
"reason": null
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"api-version": "2021-03-01-preview",
"checkNameAvailabilityParameters": {
"name": "contoso",
"type": "Microsoft.AppConfiguration/configurationStores"
}
},
"responses": {
"200": {
"body": {
"nameAvailable": false,
"reason": "AlreadyExists",
"message": "The specified name is already in use."
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"resourceGroupName": "myResourceGroup",
"configStoreName": "contoso",
"api-version": "2021-03-01-preview",
"configStoreCreationParameters": {
"location": "westus",
"sku": {
"name": "Standard"
},
"tags": {
"myTag": "myTagValue"
}
}
},
"responses": {
"200": {
"body": {
"type": "Microsoft.AppConfiguration/configurationStores",
"properties": {
"provisioningState": "Succeeded",
"creationDate": "2018-04-24T16:30:55+00:00",
"endpoint": "https://contoso.azconfig.io",
"encryption": {
"keyVaultProperties": {
"keyIdentifier": null,
"identityClientId": null
}
},
"disableLocalAuth": false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disableLocalAuth [](start = 11, length = 16)

since this is not a read-only property you should add examples where this is also specified in the request body for put and patch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add examples and update the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varunkumta Looks this could be a validation rule candidate in our swagger validation pipeline. How about adding a new rule to check swagger property coverage? make sure all non readonly property must have a related example.

"privateEndpointConnections": []
},
"systemData": {
"createdBy": "[email protected]",
"createdByType": "User",
"createdAt": "2018-04-24T16:30:55+00:00",
"lastModifiedBy": "[email protected]",
"lastModifiedByType": "User",
"lastModifiedAt": "2018-04-24T16:30:55+00:00"
},
"sku": {
"name": "Standard"
},
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso",
"name": "contoso",
"location": "westus",
"tags": {
"myTag": "myTagValue"
}
}
},
"201": {
"body": {
"type": "Microsoft.AppConfiguration/configurationStores",
"properties": {
"provisioningState": "Creating",
"creationDate": "2018-04-24T16:30:55+00:00",
"endpoint": "https://contoso.azconfig.io",
"encryption": {
"keyVaultProperties": {
"keyIdentifier": null,
"identityClientId": null
}
},
"disableLocalAuth": false,
"privateEndpointConnections": []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the removal of publicNetworkAccess here intentional? your list api examples still have this property and so does your swagger

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varunkumta this is intentional. publicNetworkAccess doesn't get returned until it is set. Since it isn't in the creation parameters in this example it wouldn't be returned. I noticed this inconsistency when I was editing the example.

It's in the list APIs because those demonstrate most properties having already been set.

},
"systemData": {
"createdBy": "[email protected]",
"createdByType": "User",
"createdAt": "2018-04-24T16:30:55+00:00",
"lastModifiedBy": "[email protected]",
"lastModifiedByType": "User",
"lastModifiedAt": "2018-04-24T16:30:55+00:00"
},
"sku": {
"name": "Standard"
},
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso",
"name": "contoso",
"location": "westus",
"tags": {
"myTag": "myTagValue"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"resourceGroupName": "myResourceGroup",
"configStoreName": "contoso",
"api-version": "2021-03-01-preview",
"keyValueName": "myKey$myLabel",
"keyValueParameters": {
"properties": {
"value": "myValue",
"tags": {
"tag1": "tagValue1",
"tag2": "tagValue2"
}
}
}
},
"responses": {
"200": {
"body": {
"type": "Microsoft.AppConfiguration/configurationStores/keyValues",
"properties": {
"key": "myKey",
"label": "myLabel",
"value": "myValue",
"contentType": "",
"eTag": "IhDxoa8VkXxPsYsemBlxvV0d5fp",
"lastModified": "2020-06-23T06:42:24+00:00",
"locked": false,
"tags": {
"tag1": "tagValue1",
"tag2": "tagValue2"
}
},
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso/keyValues/myKey$myLabel",
"name": "myKey$myLabel"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"resourceGroupName": "myResourceGroup",
"configStoreName": "contoso",
"privateEndpointConnectionName": "myConnection",
"api-version": "2021-03-01-preview",
"privateEndpointConnection": {
"properties": {
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved"
}
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso/privateEndpointConnections/myConnection",
"name": "myConnection",
"type": "Microsoft.AppConfiguration/configurationStores/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
}
}
},
"201": {
"body": {
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso/privateEndpointConnections/myConnection",
"name": "myConnection",
"type": "Microsoft.AppConfiguration/configurationStores/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
{
"parameters": {
"subscriptionId": "c80fb759-c965-4c6a-9110-9b2b2d038882",
"resourceGroupName": "myResourceGroup",
"configStoreName": "contoso",
"api-version": "2021-03-01-preview",
"configStoreCreationParameters": {
"location": "westus",
"sku": {
"name": "Standard"
},
"tags": {
"myTag": "myTagValue"
},
"identity": {
"type": "SystemAssigned, UserAssigned",
"userAssignedIdentities": {
"/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourcegroups/myResourceGroup1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity2": {}
}
}
}
},
"responses": {
"200": {
"body": {
"type": "Microsoft.AppConfiguration/configurationStores",
"properties": {
"provisioningState": "Succeeded",
"creationDate": "2018-04-24T16:30:55+00:00",
"endpoint": "https://contoso.azconfig.io",
"encryption": {
"keyVaultProperties": {
"keyIdentifier": null,
"identityClientId": null
}
},
"disableLocalAuth": false,
"privateEndpointConnections": []
},
"systemData": {
"createdBy": "[email protected]",
"createdByType": "User",
"createdAt": "2018-04-24T16:30:55+00:00",
"lastModifiedBy": "[email protected]",
"lastModifiedByType": "User",
"lastModifiedAt": "2018-04-24T16:30:55+00:00"
},
"sku": {
"name": "Standard"
},
"identity": {
"principalId": "AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAA",
"tenantId": "BBBBBBBB-BBBB-BBBB-BBBB-BBBBBBBBBBBB",
"type": "SystemAssigned, UserAssigned",
"userAssignedIdentities": {
"/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourcegroups/myResourceGroup1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity2": {
"clientId": "CCCCCCCC-CCCC-CCCC-CCCC-CCCCCCCCCCCC",
"principalId": "DDDDDDDD-DDDD-DDDD-DDDD-DDDDDDDDDDDD"
}
}
},
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso",
"name": "contoso",
"location": "westus",
"tags": {
"myTag": "myTagValue"
}
}
},
"201": {
"body": {
"type": "Microsoft.AppConfiguration/configurationStores",
"properties": {
"provisioningState": "Creating",
"creationDate": "2018-04-24T16:30:55+00:00",
"endpoint": "https://contoso.azconfig.io",
"encryption": {
"keyVaultProperties": {
"keyIdentifier": null,
"identityClientId": null
}
},
"disableLocalAuth": false,
"privateEndpointConnections": []
},
"systemData": {
"createdBy": "[email protected]",
"createdByType": "User",
"createdAt": "2018-04-24T16:30:55+00:00",
"lastModifiedBy": "[email protected]",
"lastModifiedByType": "User",
"lastModifiedAt": "2018-04-24T16:30:55+00:00"
},
"sku": {
"name": "Standard"
},
"identity": {
"principalId": "AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAA",
"tenantId": "BBBBBBBB-BBBB-BBBB-BBBB-BBBBBBBBBBBB",
"type": "SystemAssigned, UserAssigned",
"userAssignedIdentities": {
"/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourcegroups/myResourceGroup1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity2": {
"clientId": "CCCCCCCC-CCCC-CCCC-CCCC-CCCCCCCCCCCC",
"principalId": "DDDDDDDD-DDDD-DDDD-DDDD-DDDDDDDDDDDD"
}
}
},
"id": "/subscriptions/c80fb759-c965-4c6a-9110-9b2b2d038882/resourceGroups/myResourceGroup/providers/Microsoft.AppConfiguration/configurationStores/contoso",
"name": "contoso",
"location": "westus",
"tags": {
"myTag": "myTagValue"
}
}
}
}
}
Loading