Added missing APIs in Synapse Swagger. #12424

amoghnatu · 2021-01-13T23:03:39Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-13T23:03:43Z

Hi, @amoghnatu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-01-13T23:03:43Z

Swagger Validation Report

️❌BreakingChange: 21 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2019-06-01-preview/bigDataPool.json <---> new: preview/2019-06-01-preview/bigDataPool.json
- original: preview/2019-06-01-preview/privateLinkResources.json <---> new: preview/2019-06-01-preview/privateLinkResources.json
- original: preview/2019-06-01-preview/sqlPool.json <---> new: preview/2019-06-01-preview/sqlPool.json
- original: preview/2019-06-01-preview/workspace.json <---> new: preview/2019-06-01-preview/workspace.json

Rule	Message
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: synapse/common/v1/types.json#L14:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6814:9
`❌` 1026 - TypeChanged	The new version has a different type '' than the previous one 'object'. New: common-types/resource-management/v1/types.json#L299:11 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6844:11
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v1/types.json#L281:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6829:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v1/types.json#L286:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6833:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v1/types.json#L291:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6837:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v1/types.json#L296:9 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6841:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'haveLibraryRequirementsChanged' renamed or removed? New: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L397:7 Old: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L397:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: common-types/resource-management/v1/types.json#L280:7 Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6813:7
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/privateLinkResources.json#L124:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2019-06-01-preview/privateLinkResources.json#L174:5

️⚠️LintDiff: 15 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- synapse/resource-manager/readme.md tag:package-2019-06-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- synapse/resource-manager/readme.md tag:package-2019-06-01-preview

Rule	Message
⚠️ R2017 - PutRequestResponseScheme	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SqlPoolMaintenanceWindows_CreateOrUpdate' Request Model: 'MaintenanceWindows' Response Model: '' New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1235
⚠️ R2023 - SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1176
⚠️ R2023 - SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1235
⚠️ R2064 - LROStatusCodesReturnTypeSchema	200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'SqlPoolMaintenanceWindows_CreateOrUpdate', Response code: '200' New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1280
⚠️ R3017 - GuidUsage	Guid used in model definition 'WorkspaceRepositoryConfiguration' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L1089
⚠️ R4000 - ParameterDescriptionRequired	'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L1902
⚠️ R4000 - ParameterDescriptionRequired	'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L2027
⚠️ R4021 - DescriptionAndTitleMissing	'timeRanges' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L5866
⚠️ R4021 - DescriptionAndTitleMissing	'rank' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L6286
⚠️ R4021 - DescriptionAndTitleMissing	'op' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json#L7396

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-13T23:03:44Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5dd055d. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md

️✔️@azure/arm-synapse [View full logs] [Release SDK Changes]

azure-arm-synapse-4.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
cmderr	[npmPack] created ./dist/arm-synapse.js in 1.2s

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs]Release - Generate from 5dd055d. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/[email protected]/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:305:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:40:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:170:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:18:20

️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logs] Breaking Change Detected

info	[Changelog] ## Breaking Changes
info	[Changelog]
info	[Changelog] - Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
info	[Changelog]
info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New const `SensitivityLabelRankLow`
info	[Changelog] - New const `Saturday`
info	[Changelog] - New const `Monday`
info	[Changelog] - New const `Enable`
info	[Changelog] - New const `SensitivityLabelRankHigh`
info	[Changelog] - New const `Disable`
info	[Changelog] - New const `Thursday`
info	[Changelog] - New const `Remove`
info	[Changelog] - New const `Set`
info	[Changelog] - New const `Sunday`
info	[Changelog] - New const `Tuesday`
info	[Changelog] - New const `SensitivityLabelRankMedium`
info	[Changelog] - New const `SensitivityLabelRankNone`
info	[Changelog] - New const `Friday`
info	[Changelog] - New const `SensitivityLabelRankCritical`
info	[Changelog] - New const `Wednesday`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.Get(context.Context, string, string, string) (PrivateLinkResource, error)`
info	[Changelog] - New function `NewSQLPoolMaintenanceWindowsClient(string) SQLPoolMaintenanceWindowsClient`
info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.List(context.Context, string, string) (PrivateLinkResourceListResultPage, error)`
info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdateResponder(*http.Response) (GeoBackupPolicy, error)`
info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.Update(context.Context, string, string, string, SensitivityLabelUpdateList) (autorest.Response, error)`
info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `SQLPoolColumnProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListResponder(*http.Response) (PrivateLinkResourceListResult, error)`
info	[Changelog] - New function `MaintenanceWindowOptions.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `MaintenanceWindows.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdate(context.Context, string, string, string, GeoBackupPolicy) (GeoBackupPolicy, error)`
info	[Changelog] - New function `PossibleDayOfWeekValues() []DayOfWeek`
info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewSQLPoolRecommendedSensitivityLabelsClientWithBaseURI(string, string) SQLPoolRecommendedSensitivityLabelsClient`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.UpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `DataMaskingRulesClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdatePreparer(context.Context, string, string, string, GeoBackupPolicy) (*http.Request, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.Get(context.Context, string, string, string, string) (MaintenanceWindows, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.Get(context.Context, string, string, string, string) (MaintenanceWindowOptions, error)`
info	[Changelog] - New function `NewSQLPoolMaintenanceWindowOptionsClient(string) SQLPoolMaintenanceWindowOptionsClient`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdate(context.Context, string, string, string, string, MaintenanceWindows) (autorest.Response, error)`
info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdatePreparer(context.Context, string, string, string, SensitivityLabelUpdateList) (*http.Request, error)`
info	[Changelog] - New function `PossibleSensitivityLabelUpdateKindValues() []SensitivityLabelUpdateKind`
info	[Changelog] - New function `PossibleRecommendedSensitivityLabelUpdateKindValues() []RecommendedSensitivityLabelUpdateKind`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetResponder(*http.Response) (MaintenanceWindows, error)`
info	[Changelog] - New function `DataMaskingRulesClient.GetResponder(*http.Response) (DataMaskingRule, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `DataMaskingRulesClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `*MaintenanceWindowOptions.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `RecommendedSensitivityLabelUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdateResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `NewPrivateLinkHubPrivateLinkResourcesClientWithBaseURI(string, string) PrivateLinkHubPrivateLinkResourcesClient`
info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.GetResponder(*http.Response) (MaintenanceWindowOptions, error)`
info	[Changelog] - New function `*MaintenanceWindows.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.Update(context.Context, string, string, string, RecommendedSensitivityLabelUpdateList) (autorest.Response, error)`
info	[Changelog] - New function `NewPrivateLinkHubPrivateLinkResourcesClient(string) PrivateLinkHubPrivateLinkResourcesClient`
info	[Changelog] - New function `DataMaskingRulesClient.Get(context.Context, string, string, string, string) (DataMaskingRule, error)`
info	[Changelog] - New function `SensitivityLabelUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.UpdatePreparer(context.Context, string, string, string, RecommendedSensitivityLabelUpdateList) (*http.Request, error)`
info	[Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `*SensitivityLabelUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.GetResponder(*http.Response) (PrivateLinkResource, error)`
info	[Changelog] - New function `*RecommendedSensitivityLabelUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListComplete(context.Context, string, string) (PrivateLinkResourceListResultIterator, error)`
info	[Changelog] - New function `NewSQLPoolRecommendedSensitivityLabelsClient(string) SQLPoolRecommendedSensitivityLabelsClient`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewSQLPoolMaintenanceWindowsClientWithBaseURI(string, string) SQLPoolMaintenanceWindowsClient`
info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewSQLPoolMaintenanceWindowOptionsClientWithBaseURI(string, string) SQLPoolMaintenanceWindowOptionsClient`
info	[Changelog] - New function `PossibleSensitivityLabelRankValues() []SensitivityLabelRank`
info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, MaintenanceWindows) (*http.Request, error)`
info	[Changelog] - New struct `DynamicExecutorAllocation`
info	[Changelog] - New struct `MaintenanceWindowOptions`
info	[Changelog] - New struct `MaintenanceWindowOptionsProperties`
info	[Changelog] - New struct `MaintenanceWindowTimeRange`
info	[Changelog] - New struct `MaintenanceWindows`
info	[Changelog] - New struct `MaintenanceWindowsProperties`
info	[Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdate`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateList`
info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties`
info	[Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient`
info	[Changelog] - New struct `SQLPoolMaintenanceWindowsClient`
info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
info	[Changelog] - New struct `SensitivityLabelUpdate`
info	[Changelog] - New struct `SensitivityLabelUpdateList`
info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 112 additive change(s).
info	[Changelog]
error	Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
error	The following packages are still pending:
error		preview/synapse/mgmt/2019-06-01-preview/synapse

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5dd055d. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md

️✔️synapse [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] npm WARN [email protected] No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5dd055d. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Synapse [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Synapse.1.0.0-preview.5.nupkg
- Microsoft.Azure.Management.Synapse.1.0.0-preview.5.snupkg

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 5dd055d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-16 02:19:21 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-synapse"
cmderr	[generate.py] 2021-01-16 02:19:21 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-16 02:19:21 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [POM][Skip] pom already has module sdk/synapse
cmderr	[generate.py] 2021-01-16 02:20:48 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-synapse [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-16 02:25:27 DEBUG Got artifact_id: azure-resourcemanager-synapse
cmderr	[Inst] 2021-01-16 02:25:27 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-16 02:25:27 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-16 02:25:27 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-16 02:25:27 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12424/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.1.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5dd055d. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md

️✔️azure-mgmt-synapse [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-synapse
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-synapse
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.synapse
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.synapse
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.synapse
cmderr	[changelogReport] INFO:__main__:Report written to sdk/synapse/azure-mgmt-synapse/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-synapse on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.3.0', '0.4.0', '0.5.0', '0.6.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.6.0 of azure-mgmt-synapse in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.synapse
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.synapse
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.synapse
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/synapse/azure-mgmt-synapse/code_reports/0.6.0/report.json
cmdout	[Changelog] Size of delta 6.138% size of original (original: 175428 chars, delta: 10767 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model WorkspaceRepositoryConfiguration has a new parameter tenant_id
cmdout	[Changelog]   - Model WorkspaceRepositoryConfiguration has a new parameter last_commit_id
cmdout	[Changelog]   - Model SensitivityLabel has a new parameter schema_name
cmdout	[Changelog]   - Model SensitivityLabel has a new parameter managed_by
cmdout	[Changelog]   - Model SensitivityLabel has a new parameter rank
cmdout	[Changelog]   - Model SensitivityLabel has a new parameter table_name
cmdout	[Changelog]   - Model SensitivityLabel has a new parameter column_name
cmdout	[Changelog]   - Model BigDataPoolResourceInfo has a new parameter dynamic_executor_allocation
cmdout	[Changelog]   - Model BigDataPoolResourceInfo has a new parameter cache_size
cmdout	[Changelog]   - Model Workspace has a new parameter adla_resource_id
cmdout	[Changelog]   - Model SqlPoolColumn has a new parameter is_computed
cmdout	[Changelog]   - Added operation DataMaskingRulesOperations.get
cmdout	[Changelog]   - Added operation SqlPoolSensitivityLabelsOperations.update
cmdout	[Changelog]   - Added operation SqlPoolGeoBackupPoliciesOperations.create_or_update
cmdout	[Changelog]   - Added operation group SqlPoolMaintenanceWindowsOperations
cmdout	[Changelog]   - Added operation group PrivateLinkHubPrivateLinkResourcesOperations
cmdout	[Changelog]   - Added operation group SqlPoolRecommendedSensitivityLabelsOperations
cmdout	[Changelog]   - Added operation group SqlPoolMaintenanceWindowOptionsOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Model BigDataPoolResourceInfo no longer has parameter have_library_requirements_changed
warn	Breaking change found in changelog

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=188094&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory"

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-13T23:14:27Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-01-14T07:58:06Z

Hi @amoghnatu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

qianwens · 2021-01-15T02:14:48Z

/azp run

azure-pipelines · 2021-01-15T02:15:04Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2021-01-15T02:19:06Z

Hi, @amoghnatu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @qianwens

openapi-workflow-bot · 2021-01-15T02:20:46Z

Hi @amoghnatu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

ArcturusZhang · 2021-01-15T05:43:08Z

/azp run

azure-pipelines · 2021-01-15T05:43:22Z

Azure Pipelines successfully started running 2 pipeline(s).

ArcturusZhang · 2021-01-15T06:01:51Z

The breaking changes in Go SDK are expected since we are removing that property in this PR.

j5lim

Approving from ARM side.

j5lim · 2021-01-15T17:59:48Z

...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json

@@ -5380,6 +5561,122 @@
      },
      "description": "Represents the response to a List Sql pool replication link request."
    },
+    "MaintenanceWindowOptionsProperties": {


Annotate Read-only properties with readOnly: true
https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi019-annotate-read-only-properties-with-readonly-true

* Added missing APIs in Synapse Swagger. * Fixed spell check error * Swagger correctness changes. * Fixed prettier issues * Minor correctness error fixes. * Fixed prettier check * fixed lint errors * Fixed some more missing APIs. * Added newly reported Missing API Co-authored-by: Amogh Natu <[email protected]>

Added missing APIs in Synapse Swagger.

827bf4d

openapi-assignment-bot bot assigned qianwens Jan 13, 2021

Fixed spell check error

c1b6a09

openapi-pipeline-app bot added the NewApiVersionRequired label Jan 13, 2021

JeffreyRichter approved these changes Jan 14, 2021

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 14, 2021

Swagger correctness changes.

00009c2

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 14, 2021

Amogh Natu added 3 commits January 14, 2021 10:22

Fixed prettier issues

02da263

Minor correctness error fixes.

a2306af

Fixed prettier check

ea7187d

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 15, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 15, 2021

qianwens approved these changes Jan 15, 2021

View reviewed changes

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 15, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 15, 2021

fixed lint errors

cc52f8f

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 15, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 15, 2021

j5lim self-requested a review January 15, 2021 17:48

j5lim approved these changes Jan 15, 2021

View reviewed changes

j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2021

Amogh Natu added 2 commits January 15, 2021 14:09

Fixed some more missing APIs.

d40f844

Added newly reported Missing API

09d3d75

qianwens merged commit 5dd055d into Azure:master Jan 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added missing APIs in Synapse Swagger. #12424

Added missing APIs in Synapse Swagger. #12424

amoghnatu commented Jan 13, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 13, 2021

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 13, 2021

openapi-workflow-bot bot commented Jan 14, 2021

qianwens commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 15, 2021

ArcturusZhang commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

ArcturusZhang commented Jan 15, 2021

j5lim left a comment

j5lim Jan 15, 2021

Added missing APIs in Synapse Swagger. #12424

Added missing APIs in Synapse Swagger. #12424

Conversation

amoghnatu commented Jan 13, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 13, 2021

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 13, 2021

openapi-workflow-bot bot commented Jan 14, 2021

qianwens commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 15, 2021

ArcturusZhang commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

ArcturusZhang commented Jan 15, 2021

j5lim left a comment

Choose a reason for hiding this comment

j5lim Jan 15, 2021

Choose a reason for hiding this comment

amoghnatu commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading