From 99d41487d712b377b756832822f2965363f3f3a7 Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Fri, 8 Jan 2021 14:05:56 -0800 Subject: [PATCH 1/4] testing --- .../preview/2020-04-08/file.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json index bda663023088..ff3081a010ab 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-04-08/file.json @@ -5364,13 +5364,13 @@ "ShareProtocolSettings": { "description": "Protocol settings", "type": "object", + "xml": { + "name": "ProtocolSettings" + }, "properties": { "Smb": { "description": "Settings for SMB protocol.", - "$ref": "#/definitions/ShareSmbSettings", - "xml": { - "name": "SMB" - } + "$ref": "#/definitions/ShareSmbSettings" } } }, @@ -5564,6 +5564,9 @@ "ShareSmbSettings": { "description": "Settings for SMB protocol.", "type": "object", + "xml": { + "name": "SMB" + }, "properties": { "Multichannel": { "description": "Settings for SMB Multichannel.", @@ -5595,10 +5598,7 @@ }, "Protocol": { "description": "Protocol settings", - "$ref":"#/definitions/ShareProtocolSettings", - "xml": { - "name": "ProtocolSettings" - } + "$ref":"#/definitions/ShareProtocolSettings" } } }, From e804a0c8f77a78df947757db94fcb3e0878d93af Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Fri, 8 Jan 2021 15:41:44 -0800 Subject: [PATCH 2/4] removed more fileshare ignored xml names --- .../preview/2019-12-12/file.json | 8 ++++---- .../preview/2020-02-10/file.json | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json index 3c87d03b9de1..fd3b3e9e1abb 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json @@ -4610,10 +4610,7 @@ "properties": { "SmbSettings": { "description": "Settings for SMB protocol.", - "$ref": "#/definitions/SmbSettings", - "xml": { - "name": "SMB" - } + "$ref": "#/definitions/SmbSettings" } } }, @@ -4785,6 +4782,9 @@ "SmbSettings": { "description": "Settings for SMB protocol.", "type": "object", + "xml": { + "name": "SMB" + }, "properties": { "Multichannel": { "description": "Settings for SMB Multichannel.", diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json index bc8f583e84a5..ea904522c35e 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json @@ -5336,13 +5336,13 @@ "ShareProtocolSettings": { "description": "Protocol settings", "type": "object", + "xml": { + "name": "ProtocolSettings" + }, "properties": { "Smb": { "description": "Settings for SMB protocol.", - "$ref": "#/definitions/ShareSmbSettings", - "xml": { - "name": "SMB" - } + "$ref": "#/definitions/ShareSmbSettings" } } }, @@ -5530,6 +5530,9 @@ "ShareSmbSettings": { "description": "Settings for SMB protocol.", "type": "object", + "xml": { + "name": "SMB" + }, "properties": { "Multichannel": { "description": "Settings for SMB Multichannel.", @@ -5561,10 +5564,7 @@ }, "Protocol": { "description": "Protocol settings", - "$ref":"#/definitions/ShareProtocolSettings", - "xml": { - "name": "ProtocolSettings" - } + "$ref":"#/definitions/ShareProtocolSettings" } } }, From b7008ed23b38bfc09430591b710be7d7090dc39a Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Mon, 11 Jan 2021 12:35:33 -0800 Subject: [PATCH 3/4] fixed silly indents --- .../Microsoft.FileStorage/preview/2019-12-12/file.json | 2 +- .../Microsoft.FileStorage/preview/2020-02-10/file.json | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json index fd3b3e9e1abb..627d88cbc135 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json @@ -4784,7 +4784,7 @@ "type": "object", "xml": { "name": "SMB" - }, + }, "properties": { "Multichannel": { "description": "Settings for SMB Multichannel.", diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json index ea904522c35e..6ee5d29c018c 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2020-02-10/file.json @@ -5337,8 +5337,8 @@ "description": "Protocol settings", "type": "object", "xml": { - "name": "ProtocolSettings" - }, + "name": "ProtocolSettings" + }, "properties": { "Smb": { "description": "Settings for SMB protocol.", @@ -5531,8 +5531,8 @@ "description": "Settings for SMB protocol.", "type": "object", "xml": { - "name": "SMB" - }, + "name": "SMB" + }, "properties": { "Multichannel": { "description": "Settings for SMB Multichannel.", From 38b516681ea8e212176a1a9cf3d969491e5696ca Mon Sep 17 00:00:00 2001 From: Tamer Sherif Date: Mon, 11 Jan 2021 12:38:53 -0800 Subject: [PATCH 4/4] fixed silly indents --- .../Microsoft.FileStorage/preview/2019-12-12/file.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json index 627d88cbc135..a8c84cd3fc7e 100644 --- a/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json +++ b/specification/storage/data-plane/Microsoft.FileStorage/preview/2019-12-12/file.json @@ -4783,7 +4783,7 @@ "description": "Settings for SMB protocol.", "type": "object", "xml": { - "name": "SMB" + "name": "SMB" }, "properties": { "Multichannel": {