VMGuestPatch: Reverting WindowsPatchSettings back to patchSettings and adding [Preview Feature] tag to all preview properties for vm guest patch #12295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d adding [Preview Feature] tag to all preview properties for vm guest patch
rane-rajasi
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @rane-rajasi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableHotpatching New: Microsoft.Compute/stable/2020-12-01/compute.json#L12606 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-12-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 8 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2016-04-30-preview/compute.json <---> new: stable/2020-12-01/compute.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 4 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-06-01/compute.json <---> new: stable/2020-12-01/compute.json
Swagger Generation Artifacts
|
|
Hi @rane-rajasi, Your PR has some issues. Please fix the CI sequentially by following the order of
|
rane-rajasi
added a commit
to rane-rajasi/azure-sdk-for-net
that referenced
this pull request
Jan 6, 2021
This was referenced Jan 6, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
JeffreyRichter
approved these changes
Jan 6, 2021
This was referenced Jan 6, 2021
|
The warnings in the OpenAPI checks are expected for now. The branch this is based on has changes to the readme, and the indicated changed properties were removed and approved by the Breaking change reviewers. |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Additional Notes: As mentioned earlier, this PR updates properties, previously modified by this PR:#11768, which is in compute-2020-12 branch. The relevant SDK changes will be made in it's corresponding SDK PR: Azure/azure-sdk-for-net#17184, which includes the first swagger PR changes