Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alertmanagement #10000

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Alertmanagement #10000

merged 7 commits into from
Sep 1, 2020

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Jul 1, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 1, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chunyu3 chunyu3 requested a review from RodgeFu July 1, 2020 04:46
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0490165 with merge commit aa96f13. SDK Automation 13.0.17.20200828.8
  • ️✔️azure-mgmt-alertsmanagement [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-alertsmanagement
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-alertsmanagement
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 2.320% size of original (original: 35165 chars, delta: 816 chars)
    [ChangeLog] 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

Trenton Generation - Release

  • Installation instruction for service alertsmanagement [Preview Changes]
    az artifacts universal download --organization "https://dev.azure.com/azure-sdk/" --project "internal" --scope project --feed "sdk-automation-test" --name terraform-provider-azurerm --version 0.517169.1 --path .
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0490165 with merge commit aa96f13. Trenton Automation 13.0.17.20200828.8
    Failed to close the generation pull request at https://github.com/Azure/azure-sdk-for-trenton/pull/37: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 01 Sep 2020 03:12:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0785:07E6:3D03BB7:66C9976:5F4DBC33","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14744","x-ratelimit-reset":"1598931596","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/Azure/azure-sdk-for-trenton/git/refs/heads/sdkAutomation/alertsmanagement@10000","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'Diagnostics' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagedResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRuleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Suppression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionGroup' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PatchObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'operationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alert' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertModification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertModificationItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsSummary' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsMetaData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'alertsMetaDataProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MonitorServiceList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MonitorServiceDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'errorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModificationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupModificationItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroupsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'smartGroup' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionGroupsInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ThrottlingInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulePatchObject' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Detector' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulePatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/EmptyParentSchemaWarning): Schema 'Suppression' has an allOf list with an empty object schema as a parent, removing it.
    [AutoRest] WARNING (PreCheck/EmptyParentSchemaWarning): Schema 'ActionGroup' has an allOf list with an empty object schema as a parent, removing it.
    [AutoRest] WARNING (PreCheck/EmptyParentSchemaWarning): Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it.
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named errorResponse -- properties.error.$ref: undefined => "#/components/schemas/schemas:108" 
    [AutoRest] WARNING (PreCheck/DuplicateSchema): Duplicate Schema named errorResponseBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:112" 
    [AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
    [AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response' -> 'error_responseAutoGenerated'
    [AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response_body' -> 'error_response_bodyAutoGenerated'
    [AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response' -> 'error_responseAutoGenerated2'
    [AutoRest] WARNING (PreNamer/DeduplicateName): Deduplicating schema name: 'error_response_body' -> 'error_response_bodyAutoGenerated2'
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
  • ️✔️alertsmanagement [View full logs]  [Release Trenton Changes]
    [build_package] go get golang.org/x/tools/cmd/goimports: open /usr/local/go/bin/goimports: permission denied
    [build_package] Ignoring --cache-directory because the cache is not yet supported on OS "Linux 5.3.0-1034-azure #35~18.04.1-Ubuntu SMP Mon Jul 13 12:54:45 UTC 2020".

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@RodgeFu
Copy link
Member

RodgeFu commented Jul 2, 2020

@chunyu3 , seems the trenton still fail?

@akning-ms
Copy link
Contributor

@chunyu3

ping @chunyu3, what is the status for this PR?it is pending for some time

@akning-ms akning-ms added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jul 24, 2020
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 10000 in repo Azure/azure-rest-api-specs

@chunyu3
Copy link
Member Author

chunyu3 commented Aug 31, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 31, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0490165 with merge commit aa96f13. Schema Automation 13.0.17.20200828.8
    [AutoRest] WARNING: Found duplicate definition for variable-named type microsoft.alertsManagement/smartDetectorAlertRules. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}'.
    [AutoRest] WARNING: Found duplicate definition for variable-named type microsoft.alertsManagement/smartDetectorAlertRules. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}'.
  • ️✔️alertsmanagement [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5641 passing (1m)
      AzureResourceSchema has no registered package commands.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @qiaozha qiaozha merged commit aa96f13 into master Sep 1, 2020
    @qiaozha qiaozha deleted the alertmanagement branch September 1, 2020 03:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants