Event hubs cluster should support passing parameters with “sku” and “location”

[neil-yechenwei]

Per the example of rest apis spec, seems passing “parameters” with “sku” and “location” is supported by “Clusters_Put" API. However, after I also checked rest api, seems event hubs cluster actually doesn’t support passing parameters with “sku” and “location” as http request body. So I am confused. If it doesn’t support to send http request body, then I cannot specify “sku” and “location” while creating event hub cluster. So I suppose passing http request body should be supported.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl.

[serkantkaraca]

It seems the sample should use a different name for SKU as below.

"sku": { "name": "Dedicated", "capacity": 1 }

REST API swagger definition is pointing to correct name.

"ClusterSku": {
  "type": "object",
  "properties": {
    "name": {
      "type": "string",
      "description": "Name of this SKU.",
      "enum": [
        "Dedicated"
      ],
      "x-ms-enum": {
        "name": "ClusterSkuName",
        "modelAsString": true
      }
    },
    "capacity": {
      "format": "int32",
      "maximum": 32,
      "minimum": 1,
      "type": "integer",
      "description": "The quantity of Event Hubs Cluster Capacity Units contained in this cluster."
    }
  },
  "required": [
    "name"
  ],
  "description": "SKU parameters particular to a cluster instance."
},

[neil-yechenwei]

@serkantkaraca , and seems Clusters_Put API doesn't support to send paramters as http request body. May I know is there any ETA for fixing this issue?

[serkantkaraca]

@neil-yechenwei I don't understand what you mean by not supporting request body. Entire JSON document is the body and you provide those in the JSON object. Did you try running the sample?

[serkantkaraca]

OK, just informed the API is being fixed right now. Sorry for misunderstanding.

[neil-yechenwei]

@serkantkaraca , Sorry for making you confuse. After checked latest code, seems the bug I proposed still hasn't been fixed. I mean parameters (I call it http request body) is missing in Cluster_PUT API, right? I think below code ("parameters") should be added into Cluster_PUT section. So could you help to fix it asap since we're blocked now? Thanks.

The code needs to be added into "Cluster_PUT" section:

{
     "name": "parameters",
     "in": "body",
     "required": true,
     "schema": {
     "$ref": "#/definitions/Cluster"
},

After applied the fix, it should be like below sample code:

"put": {
        "tags": [
          "Event Hubs Clusters"
        ],
        "operationId": "Clusters_Put",
        "x-ms-examples": {
          "ClusterPut": {
            "$ref": "./examples/Clusters/ClusterPut.json"
          }
        },
        "description": "Creates or updates an instance of an Event Hubs Cluster.",
        "parameters": [
          {
            "$ref": "../../common/v1/definitions.json#/parameters/SubscriptionIdParameter"
          },
          {
            "$ref": "../../common/v1/definitions.json#/parameters/ResourceGroupNameParameter"
          },
          {
            "$ref": "../../common/v1/definitions.json#/parameters/ClusterNameParameter"
          },
          {
            "$ref": "../../common/v1/definitions.json#/parameters/ApiVersionParameter"
          },
          {
            "name": "parameters",
            "in": "body",
            "required": true,
            "schema": {
              "$ref": "#/definitions/Cluster"
            },
            "description": "The properties of the Event Hubs Cluster which should be updated."
          }
        ],

[serkantkaraca]

Here is the PR for fix - #9596

[neil-yechenwei]

Seems the issue has been fixed. So closed it. THanks so much.