-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kusto: Wrong type of ReadWriteDatabaseProperties#isFollowed #9450
Comments
@ArcturusZhang Could you help on this go sdk issue? |
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @radennis. |
I think this should be a valid fix for the issue: diff --git a/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-02-15/kusto.json b/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-02-15/kusto.json
index 9f6452aaa..de503c5dc 100644
--- a/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-02-15/kusto.json
+++ b/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-02-15/kusto.json
@@ -2877,7 +2877,7 @@
"description": "The statistics of the database."
},
"isFollowed": {
- "type": "string",
+ "type": "boolean",
"readOnly": true,
"description": "Indicates whether the database is followed."
}
-- It seems that the real API returns a Boolean value, but the model indicates that it is a string. |
Hi, I'm Dor for Kusto team. |
I'll open an PR. The question would be, if this should also be applied to the API 2019-11-09, as the property was also already available there, but also of type string. I don't know if this was intended there, or if it's also a bug within the spec. I also have to scan the Examples, if this property was used and also have to update it. Some feedback would be really good. |
Both versions need this fix. I've checked and we don't use this property in the examples. |
PR is created. The rest is up to you now 😄 |
Sorry I mistakenly though you are a Microsoft employee, I will handle the PR. |
Hey @docohe,
not yet ;-) alright, just ping back as soon as the fix is out. Thanks |
Hi @jrauschenbusch a new GO SDK version is now available. |
ReadWriteDatabaseProperties#isFollowed must be of type
bool
, but is of typestring
.https://github.com/Azure/azure-rest-api-specs/blob/master/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2020-02-15/kusto.json#L2879
This leads to a unmarshal error within the Go library.
Bug reference: Azure/azure-sdk-for-go#9339
The text was updated successfully, but these errors were encountered: