Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic Settings Create API Has Inconsistent Behavior On logAnalyticsDestinationType for Certain Resource #9281

Open
magodo opened this issue Apr 30, 2020 · 10 comments
Assignees
Labels
App Services Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@magodo
Copy link
Contributor

magodo commented Apr 30, 2020

The field logAnalyticsDestinationType in the diagnostic setting Creation API is not consistent and have skew for certain resources.

  1. For some certain resource (e.g. azure app service), if the user calls diagnostic settings with logAnalyticsDestinationType set to Dedicated, the API returns successful, but the body of a following GET returns that field with null. Is it possible to raise an error if the resource doesn't support the specified destination type?
  2. For some other resource (e.g. azure API management), if the user calls diagnostic settings with logAnalyticsDestinationType absent, the API returns successful, but the body of a following GET returns that field with AzureDiagnostics, which is not documented. Is it possible to return nil as documented?

Reference

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 30, 2020
@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 30, 2020
@ArcturusZhang ArcturusZhang added App Services Service Attention Workflow: This issue is responsible by Azure service team. labels Apr 30, 2020
@ghost
Copy link

ghost commented Apr 30, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @antcp, @AzureAppServiceCLI.

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 30, 2020
@ArcturusZhang ArcturusZhang added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 30, 2020
@magodo magodo changed the title Diagnostic Settings Create API Silently Ignore logAnalyticsDestinationType for Certain Resource Diagnostic Settings Create API Has Inconsistent Behavior On logAnalyticsDestinationType for Certain Resource May 5, 2020
@lilyjma lilyjma added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 19, 2020
@eissko
Copy link

eissko commented Aug 12, 2020

Any progress on this here?

In my terraform state is always stored empty string of logAnalyticsDestinationType = "" for resource type azurerm_monitor_diagnostic_setting. It results in the change on terraform plan each time it is run.

using terraform 0.12.29
azurerm provider ">= 2.22.0"

related problems/issues:

hashicorp/terraform-provider-azurerm#6769
hashicorp/terraform-provider-azurerm#6676

@ArcturusZhang ArcturusZhang removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 13, 2020
@eissko
Copy link

eissko commented Aug 14, 2020

FYI
related issue:
hashicorp/terraform-provider-azurerm#8131

@favoretti
Copy link

@ArcturusZhang ping on this one?

@ArcturusZhang
Copy link
Member

This issue will need service team's attention to resolve.
Ping @antcp, @AzureAppServiceCLI

@bm77525-kr
Copy link

Any updates here @ArcturusZhang?

@aaronswainonset
Copy link

Any update on this?

@SenorRagequit
Copy link

Is anyone even working on this module?
This issue has been brought up many times and is still not fixed, just like the bug with the re-deploying of diagnostic settings, as the metrics get set to 0 instead of NULL.

@magodo
Copy link
Contributor Author

magodo commented Apr 28, 2022

Ping @akning-ms, can we priotirize this issue as it is keeping impacting users, for a long while.

@ritik-gupta-bzy
Copy link

any updates on this issue? Still, the behavior is the same for some resources (for example: when setting up azurerm_monitor_diagnostic_setting setting using terraform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

10 participants