[suppressions.yaml] Add PR label when edited

[mikeharder]

When a PR includes edits to any file named suppressions.yaml, add a label that blocks merging (and an associated label to unblock merging). Options:

• SuppressionReviewRequired / Approved-Suppression
  • Existing labels shared by all suppressions
• SuppressionsYamlReviewRequired
  • New label for all changes to suppressions.yaml
• TypesSpecReviewRequired
  • New label specific to TypeSpecRequirement

[konrad-jamrozik]

This builds on:

• [TypeSpec Requirement] Add suppression mechanism #27348

[konrad-jamrozik]

@mikeharder

I think we should make the label as specific as possible, and also at least try to align with existing naming conventions. I just wrote down all the complexities of suppressions we have here:

• Documentation: Spec PR tools suppressions mechanisms reference azure-sdk-tools#8133

I think we could adopt a convention similar to the sdk-suppresions.yaml labels

For example, they have BreakingChange-Go-Sdk-Suppression and BreakingChange-Go-Sdk-Suppression-Approved.

Given we have:

- tool: TypeSpecRequirement

We could do:

• Tool-TypeSpecRequirement-Suppression
• Tool-TypeSpecRequirement-Suppression-Approved.

Later on, if we do e.g. - tool: BreakingChangeCrossVersion we would do:

• Tool-BreakingChangeCrossVersion-Suppression
• Tool-BreakingChangeCrossVersion-Suppression-Approved

I am suggesting to prefix this with Tool- to distinguish it from the two different kinds of suppressions: the AutoRest README.md suppressions and sdk-suppressions.yaml. See Azure/azure-sdk-tools#8133 for details.

We probably also should rename SuppresionReviewRequired to match the new convention. I filed an issue for this:

• Rename SuppressionReviewRequired and Approved-Suppression azure-sdk-tools#8135

---

Note we also need to integrate any newly added suppression labels into the Next Steps to Merge comment. This can be done in a similar way SuppressionReviewRequired is currently handled. I provided source pointers to it in this issue.

This relates to:

• Block ARM review approval (label ARMSignedOff) if suppressions have not been addressed (related to "suppression review queue") azure-sdk-tools#7908