Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ContainerRegistry] TaskStepProperties's type is incorrectly marked as read-only #13891

Open
mikhailshilkov opened this issue Apr 12, 2021 · 5 comments · Fixed by #13971
Open

[ContainerRegistry] TaskStepProperties's type is incorrectly marked as read-only #13891

mikhailshilkov opened this issue Apr 12, 2021 · 5 comments · Fixed by #13971
Labels
Container Registry question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@mikhailshilkov
Copy link
Contributor

mikhailshilkov commented Apr 12, 2021 •
edited
Loading

The containerregistry_build spec (I'm looking at the version 2019-04-01) marks the type property of the TaskStepProperties schema as read-only:

azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2019-04-01/containerregistry_build.json

Line 1287 in 73d51f1

"readOnly": true,

This looks wrong to me because the client is supposed to set this value to "Docker"/"EncodedTask"/"FileTask" depending on which derived type they want to use.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 12, 2021
@mikhailshilkov mikhailshilkov mentioned this issue Apr 12, 2021
Closed
@guidola
Copy link

guidola commented Apr 12, 2021

Indeed, as the spec is using swagger 2.0 that field needs to be readOnly: true , otherwise the polymorphism cannot be properly resolved as the discriminator requires it for such purpose.

This is breaking functionality on the endpoint.

@leni-msft leni-msft added Container Registry Service Attention Workflow: This issue is responsible by Azure service team. labels Apr 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 13, 2021
@ghost
Copy link

ghost commented Apr 13, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @toddysm, @yugangw-msft.

Issue Details

The containerregistry_build spec (I'm looking at the version 2019-04-01) marks the type property of the TaskStepProperties schema as read-only:

azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2019-04-01/containerregistry_build.json

Line 1287 in 73d51f1

"readOnly": true,

This looks wrong to me because the client is supposed to set this value to "Docker"/"EncodedTask"/"FileTask" depending on which derived type they want to use.

Author: mikhailshilkov
Assignees: leni-msft, raych1
Labels:

Container Registry, Service Attention, needs-triage, question
Milestone: -

@northtyphoon
Copy link
Member

@mikhailshilkov thanks for reporting the issue. Can you use the following version? The read-only issue has been fixed.

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json#L2196

@mikhailshilkov
Copy link
Contributor Author

Oh, that's good to know! Do you know when the next stable (non-preview) version is going to be published?

@xyxyxyxyxyxy
Copy link
Contributor

@mikhailshilkov thank you very much for reporting the issue. It is fixed in our most recent GA version now.
#13971

@northtyphoon northtyphoon linked a pull request Apr 22, 2021 that will close this issue
TaskStepProperties swagger fix #13971
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Container Registry question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TaskStepProperties swagger fix xyxyxyxyxyxy/azure-rest-api-specs
6 participants
@mikhailshilkov @northtyphoon @leni-msft @guidola @raych1 @xyxyxyxyxyxy