Skip to content

Commit

Permalink
Adding missing dividePerInstance property to Autoscale MetricTrigger (#…
Browse files Browse the repository at this point in the history 
…13991)

* Add dividePerInstance property to the autoscale metric trigger

* Update examples for autoscale to include 'dividePerInstance'

* Update examples for correctness

* update example for correctness
  • Loading branch information
@LeoVannelli
LeoVannelli authored May 7, 2021
1 parent 7f3fdac commit c1478e2
Show file tree
Hide file tree
Showing 6 changed files with 68 additions and 32 deletions.
4 changes: 4 additions & 0 deletions ...fication/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/autoscale_API.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,10 @@
"$ref": "#/definitions/ScaleRuleMetricDimension"
},
"description": "List of dimension conditions. For example: [{\"DimensionName\":\"AppName\",\"Operator\":\"Equals\",\"Values\":[\"App1\"]},{\"DimensionName\":\"Deployment\",\"Operator\":\"Equals\",\"Values\":[\"default\"]}]."
},
"dividePerInstance": {
"type": "boolean",
"description": "a value indicating whether metric should divide per instance."
}
},
"description": "The trigger that results in a scaling action."
Expand Down
36 changes: 24 additions & 12 deletions ...manager/Microsoft.Insights/stable/2015-04-01/examples/createOrUpdateAutoscaleSetting.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -44,7 +45,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -77,7 +79,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -95,7 +98,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -176,7 +180,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -194,7 +199,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -227,7 +233,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -245,7 +252,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -326,7 +334,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -344,7 +353,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -377,7 +387,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -395,7 +406,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down
12 changes: 8 additions & 4 deletions ...r/resource-manager/Microsoft.Insights/stable/2015-04-01/examples/getAutoscaleSetting.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -53,7 +54,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -86,7 +88,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -104,7 +107,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down
12 changes: 8 additions & 4 deletions .../resource-manager/Microsoft.Insights/stable/2015-04-01/examples/listAutoscaleSetting.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -54,7 +55,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -87,7 +89,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -105,7 +108,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down
12 changes: 8 additions & 4 deletions ...ger/Microsoft.Insights/stable/2015-04-01/examples/listAutoscaleSettingBySubscription.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -53,7 +54,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -86,7 +88,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -104,7 +107,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down
24 changes: 16 additions & 8 deletions ...resource-manager/Microsoft.Insights/stable/2015-04-01/examples/patchAutoscaleSetting.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -45,7 +46,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -78,7 +80,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -96,7 +99,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -177,7 +181,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -195,7 +200,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down Expand Up @@ -228,7 +234,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 10.0
"threshold": 10.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Increase",
Expand All @@ -246,7 +253,8 @@
"timeWindow": "PT5M",
"timeAggregation": "Average",
"operator": "GreaterThan",
"threshold": 15.0
"threshold": 15.0,
"dividePerInstance": false
},
"scaleAction": {
"direction": "Decrease",
Expand Down

0 comments on commit c1478e2

Please sign in to comment.