From 6629d0bc864ab74d4bc1c3601ed97d585537eeb5 Mon Sep 17 00:00:00 2001 From: mqwang Date: Mon, 17 Jul 2023 10:12:30 -0700 Subject: [PATCH] Add enableOSPatching and address comments (#24849) --- .../Compute/createOrUpdate/AmlCompute.json | 1 - .../createOrUpdate/ComputeInstance.json | 2 ++ .../examples/Compute/get/AmlCompute.json | 1 - .../examples/Compute/get/ComputeInstance.json | 2 ++ .../machineLearningServices.json | 22 ++++++++++--------- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/AmlCompute.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/AmlCompute.json index b5abb100bc88..52d57363df95 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/AmlCompute.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/AmlCompute.json @@ -48,7 +48,6 @@ "nodeIdleTimeBeforeScaleDown": "PT5M" }, "remoteLoginPortPublicAccess": "Enabled", - "releaseQuotaOnStop": false, "allocationState": "Resizing", "allocationStateTransitionTime": "2017-09-27T22:28:08.998Z", "errors": null, diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/ComputeInstance.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/ComputeInstance.json index 7f7ed8aa80c2..27520dee9715 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/ComputeInstance.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/createOrUpdate/ComputeInstance.json @@ -21,6 +21,8 @@ "sshSettings": { "sshPublicAccess": "Disabled" }, + "enableOSPatching": true, + "releaseQuotaOnStop": true, "customServices": [ { "name": "rstudio-workbench", diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/AmlCompute.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/AmlCompute.json index f666b7400de8..486c8195cebb 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/AmlCompute.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/AmlCompute.json @@ -34,7 +34,6 @@ "nodeIdleTimeBeforeScaleDown": "PT5M" }, "remoteLoginPortPublicAccess": "Enabled", - "releaseQuotaOnStop": false, "allocationState": "Resizing", "allocationStateTransitionTime": "2017-09-27T22:28:08.998Z", "errors": null, diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/ComputeInstance.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/ComputeInstance.json index e71fb00c97de..8f4ae388a5ad 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/ComputeInstance.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/Compute/get/ComputeInstance.json @@ -35,6 +35,8 @@ "latestImageVersion": "22.07.22", "isLatestOsImageVersion": false }, + "enableOSPatching": true, + "releaseQuotaOnStop": true, "customServices": [ { "name": "rstudio-workbench", diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index e007af09dfc5..d3b51581910d 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -1906,14 +1906,7 @@ "name": "remoteLoginPortPublicAccess", "modelAsString": true } - }, - "releaseQuotaOnStop": { - "type": "boolean", - "default": false, - "title": "Release quota if compute instance stopped.", - "description": "Release quota if compute instance stopped. Possible values are: true - release quota if compute instance stopped. false - don't release quota when compute instance stopped.", - "x-nullable": true - }, + }, "allocationState": { "type": "string", "readOnly": true, @@ -2113,11 +2106,20 @@ "modelAsString": true } }, + "enableOSPatching": { + "type": "boolean", + "default": false, + "title": "Enable Auto OS Patching.", + "description": "Enable Auto OS Patching. Possible values are: true, false.", + "x-nullable": true + }, "releaseQuotaOnStop": { "type": "boolean", + "default": false, "title": "Release quota if compute instance stopped.", - "description": "Release quota if compute instance stopped. Possible values are: true - release quota if compute instance stopped. false - don't release quota when compute instance stopped." - }, + "description": "Release quota if compute instance stopped. Possible values are: true - release quota if compute instance stopped. false - don't release quota when compute instance stopped.", + "x-nullable": true + }, "personalComputeInstanceSettings": { "title": "Personal Compute Instance settings.", "description": "Settings for a personal compute instance.",