From e33ac60d1ca4f079c760fe1c9955e09364fd9402 Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Wed, 8 Jun 2022 21:23:06 +0800
Subject: [PATCH 1/6] Fix Az.Monitor XML Comments

---
 src/Monitor/Monitor/Monitor.csproj                       | 9 +++++++++
 .../Monitor/OutputClasses/PSDynamicMetricCriteria.cs     | 2 +-
 src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs   | 6 +++---
 .../Monitor/OutputClasses/PSPrivateEndpointConnection.cs | 5 ++++-
 src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs     | 2 +-
 .../Monitor/TransitionalClasses/AutoscaleNotification.cs | 1 -
 .../Monitor/TransitionalClasses/MetricSettings.cs        | 2 +-
 7 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index adbe579cf437..896fe3afc2ce 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,6 +8,15 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
+    <GenerateDocumentationFile>True</GenerateDocumentationFile>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <NoWarn>1701;1702 ;1591</NoWarn>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <NoWarn>1701;1702 ;1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs b/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
index 6a17bbebd29a..71c64c1a7a35 100644
--- a/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
@@ -29,7 +29,7 @@ public class PSDynamicMetricCriteria : DynamicMetricCriteria, IPSMultiMetricCrit
         /// <summary>
         /// Initiliazes a PS object for dynamic metric criteria
         /// </summary>
-        /// <param name="metricCriteria">The original dynamic metric criteria object</param>
+        /// <param name="dynamicMetricCriteria"></param>
         public PSDynamicMetricCriteria(DynamicMetricCriteria dynamicMetricCriteria): 
             base(name: dynamicMetricCriteria.Name, 
                 metricName: dynamicMetricCriteria.MetricName, 
diff --git a/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs b/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
index 65354c2efb9a..60bbe527dc2c 100644
--- a/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
@@ -22,9 +22,9 @@ public class PSMetricDimension
         /// <summary>
         /// Initializes a new instance of the MetricDimension class.
         /// </summary>
-        /// <param name="dimension">Name of the dimension.</param>
-        /// <param name="includeValues">List dimension includeValues.</param>
-        /// <param name="excludeValues">List of dimension excludeValues.</param>
+        /// <param name="dimensionName"></param>
+        /// <param name="valuesToInclude"></param>
+        /// <param name="valuesToExclude"></param>
 
         public PSMetricDimension(string dimensionName, string[] valuesToInclude, string[] valuesToExclude)
         {
diff --git a/src/Monitor/Monitor/OutputClasses/PSPrivateEndpointConnection.cs b/src/Monitor/Monitor/OutputClasses/PSPrivateEndpointConnection.cs
index d82f065ebd13..9efa51aa3738 100644
--- a/src/Monitor/Monitor/OutputClasses/PSPrivateEndpointConnection.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSPrivateEndpointConnection.cs
@@ -24,10 +24,13 @@ namespace Microsoft.Azure.Commands.Insights.OutputClasses
     /// 
     [JsonTransformation]
     public class PSPrivateEndpointConnection
-    {       
+    {
         /// <summary>
         /// Initializes a new instance of the PrivateEndpointConnection class.
         /// </summary>
+        /// <param name="id"></param>
+        /// <param name="name"></param>
+        /// <param name="type"></param>
         /// <param name="privateEndpoint">Private endpoint which the connection
         /// belongs to.</param>
         /// <param name="privateLinkServiceConnectionState">Connection state of
diff --git a/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs b/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
index e415865c5074..d65930ff3a2d 100644
--- a/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
@@ -25,7 +25,7 @@ public class PSVoiceReceiver : PSActionGroupReceiverBase
         // <summary>Gets or sets the country code.</summary>
         public string CountryCode { get; set; }
 
-        /// <summary>Gets or sets the phone number.</summar>
+        /// <summary>Gets or sets the phone number.</summary>
         public string PhoneNumber { get; set; }
 
         /// <summary>Initializes a new instance of the PSVoiceReceiver class</summary>
diff --git a/src/Monitor/Monitor/TransitionalClasses/AutoscaleNotification.cs b/src/Monitor/Monitor/TransitionalClasses/AutoscaleNotification.cs
index e2a69a48927f..f75be6bec336 100644
--- a/src/Monitor/Monitor/TransitionalClasses/AutoscaleNotification.cs
+++ b/src/Monitor/Monitor/TransitionalClasses/AutoscaleNotification.cs
@@ -44,7 +44,6 @@ public class AutoscaleNotification : Monitor.Models.AutoscaleNotification
         /// <summary>
         /// Initializes a new instance of the AutoscaleNotification class.
         /// </summary>
-        /// <param name="autoscaleNotification">The autoscale notification</param>
         public AutoscaleNotification()
             : base()
         {
diff --git a/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs b/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
index 430feb5b3ef7..62094b0a9877 100644
--- a/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
+++ b/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
@@ -35,7 +35,7 @@ public class MetricSettings : Monitor.Models.MetricSettings
         /// <summary>
         /// Initializes a new instance of the MetricSettings class.
         /// </summary>
-        /// <param name="logSettings">The metric settings</param>
+        /// <param name="metricSettings"></param>
         public MetricSettings(Monitor.Models.MetricSettings metricSettings)
             : base()
         {

From bb11d7840d88ce929fd595ecf91afbdf48c0e1ed Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Wed, 8 Jun 2022 21:28:53 +0800
Subject: [PATCH 2/6] remove changes on csproj

---
 src/Monitor/Monitor/Monitor.csproj | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index 896fe3afc2ce..adbe579cf437 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,15 +8,6 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
-    <GenerateDocumentationFile>True</GenerateDocumentationFile>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <NoWarn>1701;1702 ;1591</NoWarn>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <NoWarn>1701;1702 ;1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

From a26bf85db5912b6110a12086f3eb7943007551e9 Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Thu, 9 Jun 2022 20:27:26 +0800
Subject: [PATCH 3/6] fix //

---
 src/Monitor/Monitor/Monitor.csproj                   | 9 +++++++++
 src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index adbe579cf437..5e9ebfa70987 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,6 +8,15 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
+    <GenerateDocumentationFile>True</GenerateDocumentationFile>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <NoWarn>1701;1702; 1591</NoWarn>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <NoWarn>1701;1702; 1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs b/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
index d65930ff3a2d..09248c91b76f 100644
--- a/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSVoiceReceiver.cs
@@ -22,7 +22,7 @@ namespace Microsoft.Azure.Commands.Insights.OutputClasses
     /// </summary>
     public class PSVoiceReceiver : PSActionGroupReceiverBase
     {
-        // <summary>Gets or sets the country code.</summary>
+        /// <summary>Gets or sets the country code.</summary>
         public string CountryCode { get; set; }
 
         /// <summary>Gets or sets the phone number.</summary>

From aa94a38ba1379f4aa026efb797e5a6fca839cb66 Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Thu, 9 Jun 2022 20:29:47 +0800
Subject: [PATCH 4/6] fix //

---
 src/Monitor/Monitor/Monitor.csproj | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index 5e9ebfa70987..adbe579cf437 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,15 +8,6 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
-    <GenerateDocumentationFile>True</GenerateDocumentationFile>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <NoWarn>1701;1702; 1591</NoWarn>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <NoWarn>1701;1702; 1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

From 1e1cad56e10798b7e12bacb354f5a6c2208e1316 Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Thu, 16 Jun 2022 13:50:06 +0800
Subject: [PATCH 5/6] add desc

---
 src/Monitor/Monitor/Monitor.csproj                       | 9 +++++++++
 .../Monitor/OutputClasses/PSDynamicMetricCriteria.cs     | 2 +-
 src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs   | 6 +++---
 .../Monitor/TransitionalClasses/MetricSettings.cs        | 2 +-
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index adbe579cf437..cf077af883a9 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,6 +8,15 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
+    <GenerateDocumentationFile>True</GenerateDocumentationFile>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs b/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
index 71c64c1a7a35..39079f24514b 100644
--- a/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSDynamicMetricCriteria.cs
@@ -29,7 +29,7 @@ public class PSDynamicMetricCriteria : DynamicMetricCriteria, IPSMultiMetricCrit
         /// <summary>
         /// Initiliazes a PS object for dynamic metric criteria
         /// </summary>
-        /// <param name="dynamicMetricCriteria"></param>
+        /// <param name="dynamicMetricCriteria">The original dynamic metric criteria object</param>
         public PSDynamicMetricCriteria(DynamicMetricCriteria dynamicMetricCriteria): 
             base(name: dynamicMetricCriteria.Name, 
                 metricName: dynamicMetricCriteria.MetricName, 
diff --git a/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs b/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
index 60bbe527dc2c..b4160bd34db7 100644
--- a/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
+++ b/src/Monitor/Monitor/OutputClasses/PSMetricDimension.cs
@@ -22,9 +22,9 @@ public class PSMetricDimension
         /// <summary>
         /// Initializes a new instance of the MetricDimension class.
         /// </summary>
-        /// <param name="dimensionName"></param>
-        /// <param name="valuesToInclude"></param>
-        /// <param name="valuesToExclude"></param>
+        /// <param name="dimensionName">Name of the dimension.</param>
+        /// <param name="valuesToInclude">List dimension includeValues.</param>
+        /// <param name="valuesToExclude">List of dimension excludeValues.</param>
 
         public PSMetricDimension(string dimensionName, string[] valuesToInclude, string[] valuesToExclude)
         {
diff --git a/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs b/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
index 62094b0a9877..0eb67653aa7a 100644
--- a/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
+++ b/src/Monitor/Monitor/TransitionalClasses/MetricSettings.cs
@@ -35,7 +35,7 @@ public class MetricSettings : Monitor.Models.MetricSettings
         /// <summary>
         /// Initializes a new instance of the MetricSettings class.
         /// </summary>
-        /// <param name="metricSettings"></param>
+        /// <param name="metricSettings">The metric settings</param>
         public MetricSettings(Monitor.Models.MetricSettings metricSettings)
             : base()
         {

From ea3b0305285c96b5df07698a1bd11ad8010a2573 Mon Sep 17 00:00:00 2001
From: Flynn <fanzzz1999@gmail.com>
Date: Thu, 16 Jun 2022 13:52:19 +0800
Subject: [PATCH 6/6] add desc

---
 src/Monitor/Monitor/Monitor.csproj | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/Monitor/Monitor/Monitor.csproj b/src/Monitor/Monitor/Monitor.csproj
index cf077af883a9..adbe579cf437 100644
--- a/src/Monitor/Monitor/Monitor.csproj
+++ b/src/Monitor/Monitor/Monitor.csproj
@@ -8,15 +8,6 @@
 
   <PropertyGroup>
     <RootNamespace>$(LegacyAssemblyPrefix)Insights</RootNamespace>
-    <GenerateDocumentationFile>True</GenerateDocumentationFile>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <NoWarn>1701;1702;1591</NoWarn>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <NoWarn>1701;1702;1591</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>