From ee4565a533c1d72ef6ce10636901c26a7e3fa5ab Mon Sep 17 00:00:00 2001 From: Maoliang Huang Date: Tue, 16 Feb 2021 14:56:31 -0800 Subject: [PATCH] Incorporate feedback. --- tools/Az.Tools.Predictor/Az.Tools.Predictor/AzContext.cs | 7 +++++++ .../Az.Tools.Predictor/InterceptSurvey.ps1 | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/AzContext.cs b/tools/Az.Tools.Predictor/Az.Tools.Predictor/AzContext.cs index 8258dc3e9181..bcb6a15a8802 100644 --- a/tools/Az.Tools.Predictor/Az.Tools.Predictor/AzContext.cs +++ b/tools/Az.Tools.Predictor/Az.Tools.Predictor/AzContext.cs @@ -101,8 +101,15 @@ public Version ModuleVersion } } + /// public bool IsInternal { get; internal set; } + /// + /// The survey session id appended to the survey. + /// + /// + /// We only collect this information in the preview. So make it internal and not to make it to the interface. + /// internal string SurveyId { get; set; } /// diff --git a/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1 b/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1 index 06934eb77b04..543fde238617 100644 --- a/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1 +++ b/tools/Az.Tools.Predictor/Az.Tools.Predictor/InterceptSurvey.ps1 @@ -12,6 +12,13 @@ # limitations under the License. # ---------------------------------------------------------------------------------- +# This file is a temporary approach to prompt the user for a survey. +# It doesn't cover every case well or not tested well: +# 1. Allow two or more modules to show the survey link. +# 2. When the major version is changed. +# 3. Not sure about the way to handle survey id or if it's needed in future. +# 4. The file format is also subject to change in future. + param ( [Parameter(Mandatory)] [string] $moduleName,