Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in public build #1519

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: typo in public build #1519

merged 1 commit into from
Jun 25, 2024

Conversation

hallvictoria
Copy link
Contributor

Description

Removed extra parameter keyword in public build.

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review June 25, 2024 21:04
@hallvictoria hallvictoria merged commit fd39060 into dev Jun 25, 2024
7 of 13 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/public-build-fix branch June 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang YunchuWang is a code owner

@pdthummar pdthummar Awaiting requested review from pdthummar pdthummar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallvictoria @gavin-aguiar