Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1ES pipeline fixes #1512

Merged
merged 45 commits into from
Jun 25, 2024
Merged

fix: 1ES pipeline fixes #1512

merged 45 commits into from
Jun 25, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Jun 14, 2024

Description

1ES security fixes
- Removed index-url for test-pypi
- Refactored dummy container key into pipeline env variable

1ES pipeline changes
- Deleted GitHub workflows
- Added public build tests: unit
- Added official build tests: docker consumption, docker dedicated LC, E2E, unit
- Refactored E2E tests to all run together
- Removed redundant steps from building / packaging scripts (PublishAndBuild task is not allowed)
- Added scheduled and PR-based integration test workflow that runs unit, E2E, and LC tests
- Added scheduled docker consumption and dedicated test workflow
- Added manual core tools & custom image test workflow

Test fixes:
- Numpy_func: to be compatible with latest major release
- Test_logging: path changes when running in ADO
- httpv2 debug logging: skipping as debug logging seems to work different in ADO (TODO: fix later)
- docker tests: installing correct dependencies to run the tests, installing base extension in container, moving httpv2 tests to separate class to help with flakiness


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.74%. Comparing base (c244569) to head (e947645).

Current head e947645 differs from pull request most recent head f3a9799

Please upload reports for the commit f3a9799 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (c244569) and HEAD (e947645). Click for more details.

HEAD has 1 upload more than BASE | Flag | BASE (c244569) | HEAD (e947645) | |------|------|------| |unittests|1|2|
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1512       +/-   ##
===========================================
- Coverage   83.03%   31.74%   -51.29%     
===========================================
  Files          36       36               
  Lines        2322     2334       +12     
  Branches      346      449      +103     
===========================================
- Hits         1928      741     -1187     
- Misses        295     1591     +1296     
+ Partials       99        2       -97     
Flag Coverage Δ
unittests 31.74% <ø> (-51.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review June 14, 2024 20:48
@hallvictoria hallvictoria marked this pull request as draft June 17, 2024 21:38
@hallvictoria hallvictoria changed the title fix: SDL fixes for code-mirror fix: 1ES pipeline fixes Jun 18, 2024
@hallvictoria hallvictoria marked this pull request as ready for review June 24, 2024 19:33
.github/workflows/perf-testing-setup.yml Outdated Show resolved Hide resolved
eng/ci/custom-image-tests.yml Show resolved Hide resolved
eng/ci/docker-tests.yml Outdated Show resolved Hide resolved
eng/templates/official/jobs/ci-dedicated-tests.yml Outdated Show resolved Hide resolved
eng/ci/docker-tests.yml Outdated Show resolved Hide resolved
eng/ci/integration-tests.yml Show resolved Hide resolved
eng/ci/public-build.yml Show resolved Hide resolved
tests/utils/testutils_docker.py Outdated Show resolved Hide resolved
@hallvictoria hallvictoria merged commit 89a54f0 into dev Jun 25, 2024
5 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/security-fixes branch June 25, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants