Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing new SB properties #1425

Merged
merged 17 commits into from
Mar 1, 2024
Merged

Testing new SB properties #1425

merged 17 commits into from
Mar 1, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Feb 7, 2024

Description

Adds testing for new properties added to ServiceBus.

Fixes https://github.com/Azure/azure-functions-pyfx-planning/issues/175


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria changed the title added extra sb properties to test Testing new SB properties Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (b97a4ad) to head (57fefa3).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1425   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files          35       35           
  Lines        1965     1965           
  Branches      370      370           
=======================================
  Hits         1676     1676           
  Misses        216      216           
  Partials       73       73           
Flag Coverage Δ
unittests 85.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review February 8, 2024 20:21
@gavin-aguiar gavin-aguiar merged commit 8f1c7b1 into dev Mar 1, 2024
51 checks passed
@gavin-aguiar gavin-aguiar deleted the hallvictoria/sb-properties branch March 1, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants