Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookie dependency #307

Open
ejizba opened this issue Oct 9, 2024 · 0 comments
Open

Remove cookie dependency #307

ejizba opened this issue Oct 9, 2024 · 0 comments

Comments

@ejizba
Copy link
Contributor

ejizba commented Oct 9, 2024

Background: The cookie package was added as a part of http stream support in this PR. Previously, the host handled cookie stuff for us, but with http streams we had to do it ourselves.

Breaking change: The easiest solution is to just remove cookie support and tell customers to use the cookie package directly in their own code if they want to use cookies. That's what my branch does. The alternative is to work with the host team so that they handle cookies for us even in the http stream scenario.

Branch to remove: ej/removeCookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant