Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom handlers] HTTP query and identities are serialized #6606

Closed
anthonychu opened this issue Sep 6, 2020 · 3 comments · Fixed by #6621
Closed

[Custom handlers] HTTP query and identities are serialized #6606

anthonychu opened this issue Sep 6, 2020 · 3 comments · Fixed by #6621

Comments

@anthonychu
Copy link
Member

This is the payload sent for an http trigger:

{
  "Url": "http:\/\/localhost:7071\/api\/HttpTrigger?name=anthony",
  "Method": "GET",
  "Query": "{\"name\":\"anthony\"}",
  "Headers": {
    "Cache-Control": [
      "max-age=0"
    ],
    "Connection": [
      "keep-alive"
    ],
    "Accept": [
      "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8,application\/signed-exchange;v=b3;q=0.9"
    ],
    "Accept-Encoding": [
      "gzip, deflate, br"
    ],
    "Accept-Language": [
      "en-CA,en-US;q=0.9,en;q=0.8"
    ],
    "Cookie": [
      "io=qlFSqVVx3njBnla2AAAH"
    ],
    "Host": [
      "localhost:7071"
    ],
    "User-Agent": [
      "Mozilla\/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/79.0.3945.117 Safari\/537.36 Edg\/79.0.309.65"
    ],
    "Upgrade-Insecure-Requests": [
      "1"
    ],
    "Sec-Fetch-User": [
      "?1"
    ],
    "Sec-Fetch-Site": [
      "none"
    ],
    "Sec-Fetch-Mode": [
      "navigate"
    ]
  },
  "Params": [],
  "Identities": "[{\"AuthenticationType\":null,\"IsAuthenticated\":false,\"Actor\":null,\"BootstrapContext\":null,\"Claims\":[],\"Label\":null,\"Name\":null,\"NameClaimType\":\"http:\/\/schemas.xmlsoap.org\/ws\/2005\/05\/identity\/claims\/name\",\"RoleClaimType\":\"http:\/\/schemas.microsoft.com\/ws\/2008\/06\/identity\/claims\/role\"}]"
}

Query and Identities should be objects, not strings.

@pragnagopa @yojagad

@pragnagopa
Copy link
Member

@anthonychu - flagging this as breaking as this a minor breaking change. Assuming we are ok with this. Sent a PR.

@anthonychu
Copy link
Member Author

Yep ok with this being breaking as this is needed for consistency. What’s the best way to let customers know?

@pragnagopa
Copy link
Member

I have updated release notes as part of the PR. I will also include in a note in the release announcement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants