Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify which host.json needs to be modified in "Setting up durable-py debugging" #68

Closed
davidmrdavid opened this issue Mar 12, 2020 · 3 comments

Comments

@davidmrdavid
Copy link
Collaborator

In the Contributor's Guide, there's a section titled "Setting up durable-py debugging" which describes changes that are needed in the host.json file. However, there are many host.json files in the repo. It would be good to acknowledge in the text that there are many such files, perhaps explain their differences, and specify which needs to be changed.

@priyaananthasankar
Copy link
Collaborator

priyaananthasankar commented Mar 25, 2020

@davidmrdavid : Will just provide a required host.json file without extension bundles for now and point a link as to how someone can configure extension bundles in the file. Will that work?

@davidmrdavid
Copy link
Collaborator Author

davidmrdavid commented Mar 25, 2020

@priyaananthasankar Sure! I'm just unsure of how this would co-exist with the current "bundles-v1"-enabled host.json files that I pushed here: #85

I'm just hoping that, if you provide that host.json, that it won't override the host.json that's necessary for non-contributors to run the sample.

In any case, I no longer believe that this issue is all that important. I've been convinced that users doing end-to-end testing should be able to realize which host.json to file to modify and how to modify it.

So perhaps this issue can now be resolved simply by providing a link or two to relevant background information that users should read before attempting to do these 'risky' / 'advanced' modifications. How does that sound?

@priyaananthasankar
Copy link
Collaborator

We provide a link to a specific starter sample and each sample has its own host.json that devs can refer to (#85 fixes this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants