Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhanced Http] Using GetHttpRequestDataAsync in enhanced http model #1543

Closed
satvu opened this issue May 16, 2023 · 2 comments · Fixed by #1612
Closed

[Enhanced Http] Using GetHttpRequestDataAsync in enhanced http model #1543

satvu opened this issue May 16, 2023 · 2 comments · Fixed by #1612
Assignees
@satvu
Labels
area: http Items related to experience improvements for HTTP triggers design needs-discussion
Milestone
ASP.NET Core Inte...

Comments

@satvu
Copy link
Member

satvu commented May 16, 2023

Discussed in #1534. We either need to make it very clear that using GetHttpRequestDataAsync is not a supported scenario or make sure it is in sync (i.e., return an HttpRequestData implementation backed by the HttpContext).
@satvu satvu added design needs-discussion area: http Items related to experience improvements for HTTP triggers labels May 16, 2023
@ghost ghost assigned fabiocav May 16, 2023
@satvu satvu added this to the Functions Sprint 147 milestone May 24, 2023
@satvu
Copy link
Member Author

satvu commented May 30, 2023

Initial design plans:

Do not support using GetHttpRequestDataAsync when asp.net integration is present. The error message will be logged and tracked, and if many users are trying out this scenario, we will consider supporting this.

@mattchenderson mattchenderson mentioned this issue Jun 7, 2023
Closed
This was referenced Jun 9, 2023
Closed
Merged
@satvu satvu linked a pull request Jun 9, 2023 that will close this issue
[Enhanced Http] GetHttpRequestDataAsync throws error in asp.net integration model #1612
Merged
7 tasks
@satvu
Copy link
Member Author

satvu commented Jun 13, 2023

Closing as finished.

@satvu satvu closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satvu satvu

Labels
area: http Items related to experience improvements for HTTP triggers design needs-discussion
Projects
None yet
Milestone
ASP.NET Core Integration - preview2
3 participants
@fabiocav @mattchenderson @satvu