-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up of the EventHubsCaptureEventGridDemo sample in the azure-event-hubs repo #479
Conversation
Thanks @zedy-wj ! @serkantkaraca, @spelluru, Please review |
@ramya-rao-a - Looks good to me. Thanks. |
samples/e2e/EventHubsCaptureEventGridDemo/DWDumper/DWDumper.csproj
Outdated
Show resolved
Hide resolved
samples/e2e/EventHubsCaptureEventGridDemo/FunctionEGDWDumper/Function1.cs
Outdated
Show resolved
Hide resolved
samples/e2e/EventHubsCaptureEventGridDemo/DWDumper/DWDumper.csproj
Outdated
Show resolved
Hide resolved
…directly,and modify reference of packages.
@ramya-rao-a Thanks for your guidance. I have updated according to your requirements. Let me know, if you have any other questions or guidance. |
Thanks @zedy-wj @jsquire, @serkantkaraca, Can you review please? |
samples/e2e/EventHubsCaptureEventGridDemo/DWDumper/DWDumper.csproj
Outdated
Show resolved
Hide resolved
samples/e2e/EventHubsCaptureEventGridDemo/WindTurbineDataGenerator/packages.config
Outdated
Show resolved
Hide resolved
Thanks @jsquire! @serkantkaraca, Waiting for your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @serkantkaraca! |
@ramya-rao-a - merging it now. Thanks. |
l have updated these file, and use new package Azure.Storage.Blobs in DWDumper project.
@ramya-rao-a , @jongio for notification.