Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of the EventHubsCaptureEventGridDemo sample in the azure-event-hubs repo #479

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Clean up of the EventHubsCaptureEventGridDemo sample in the azure-event-hubs repo #479

merged 3 commits into from
Apr 23, 2021

Conversation

zedy-wj
Copy link
Member

@zedy-wj zedy-wj commented Apr 15, 2021

  • The WindTurbineDataGenerator project does not use the old EH package anymore, but it does list it in the packages.config file and the csproj file
  • The FunctionEGDWDumper project lists Azure.Storage.Blobs (the new Storage package) in the csproj file, but uses the older Microsoft.WindowsAzure.Storage package in the Function.1.cs file
  • The DWDumper project lists the older Key Vault package in the csproj file, but does not use it anywhere in code
  • The DWDumper project also uses the older Storage package. It should use Azure.Storage.Blobs instead

l have updated these file, and use new package Azure.Storage.Blobs in DWDumper project.

@ramya-rao-a , @jongio for notification.

@ramya-rao-a
Copy link
Contributor

Thanks @zedy-wj !

@serkantkaraca, @spelluru, Please review

@spelluru
Copy link
Collaborator

@ramya-rao-a - Looks good to me. Thanks.

@zedy-wj
Copy link
Member Author

zedy-wj commented Apr 19, 2021

@ramya-rao-a Thanks for your guidance. I have updated according to your requirements. Let me know, if you have any other questions or guidance.

@ramya-rao-a
Copy link
Contributor

Thanks @zedy-wj

@jsquire, @serkantkaraca, Can you review please?

@ramya-rao-a
Copy link
Contributor

Thanks @jsquire!

@serkantkaraca, Waiting for your approval

Copy link
Member

@serkantkaraca serkantkaraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ramya-rao-a
Copy link
Contributor

Thanks @serkantkaraca!
We don't have merge permissions here. Can either you or @spelluru merge this PR?

@spelluru spelluru merged commit bffa22a into Azure:master Apr 23, 2021
@spelluru
Copy link
Collaborator

@ramya-rao-a - merging it now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants