Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointers to new packages in readme files at the root and for .Net legacy package #478

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Add pointers to new packages in readme files at the root and for .Net legacy package #478

merged 3 commits into from
Apr 16, 2021

Conversation

ramya-rao-a
Copy link
Contributor

This PR has the below changes

  • Updated the root readme file to have pointers to the new packages and their samples
  • Add missing readme file for the folder with samples for the older WindowsAzure.ServiceBus package
  • Update readme for the sample on RBAC for the older WindowsAzure.ServiceBus package to pointer to the corresponding sample in the new package

@ramya-rao-a ramya-rao-a marked this pull request as ready for review April 9, 2021 06:05
@ramya-rao-a
Copy link
Contributor Author

cc @spelluru, @serkantkaraca, @lilyjma

@ramya-rao-a ramya-rao-a changed the title Add pointers to new packages in readme files Add pointers to new packages in readme files at the root and for .Net legacy package Apr 9, 2021
spelluru
spelluru approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@spelluru spelluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good from my side. Thanks.

JamesBirdsall
JamesBirdsall approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@JamesBirdsall JamesBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ramya-rao-a
Copy link
Contributor Author

Thanks for the review and approval @JamesBirdsall

I don't have permissions to merge the PR, can you please help with that?

@JamesBirdsall JamesBirdsall merged commit 71ed5ea into Azure:master Apr 16, 2021
serkantkaraca pushed a commit that referenced this pull request Oct 18, 2024
@ramya-rao-a @serkantkaraca
Add pointers to new packages in readme files at the root and for .Net…
98580c9 
… legacy package (#478)

* Add pointers to new packages in readme files

* re-arrange readme

* Update Java readme too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBirdsall JamesBirdsall JamesBirdsall approved these changes

@spelluru spelluru spelluru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramya-rao-a @spelluru @JamesBirdsall