Updates to Lily's PR to azure-event-hubs to add pointers to new library #475
Conversation
|
|
||
| See [sample](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/samples/DefiningCustomCredentialTypes.md#authenticating-with-the-on-behalf-of-flow) that uses the new library to authenticate after the environment variables for client id and secret are set. |
There was a problem hiding this comment.
Was there any particular reason to talk about "behalf of flow" here?
There was a problem hiding this comment.
I think I was trying to find a corresponding T2 sample to point to.
There was a problem hiding this comment.
ok, I was wondering if @jsquire had any particular reason to talk about the "behalf of flow" due to the custom role set up being explained in this sample
There was a problem hiding this comment.
I would question why we're pointing at the custom credential sample. Unless I'm missing a nuance, the standard ClientSecretCredential would probably be the more relevant type; the custom role would likely be assigned to a normal service principal.
There was a problem hiding this comment.
I talked to Lily offline and it looked like she took a best guess at what would fit best.
@jsquire Can you take a look at the text under "Run the sample for current library Azure.Messaging.EventHubs" section in this file and see if that is good enough?
There was a problem hiding this comment.
I don't see that specific text, but the link that is used to point to our AAD sample is correct. I don't like our text in the sample for T2, but I'll do a quick update to fix that up.
| @@ -1,16 +1,16 @@ | |||
| # Receive events with the Event Processor Host in .NET Standard | |||
|
|
|||
| This sample shows how to write a .NET Core console application that receives a set of events from an event hub by using the **Event Processor Host** library. You can run the solution as-is, replacing the strings with your event hub and storage account values. The sample is also [available as a tutorial](https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-dotnet-standard-getstarted-receive-eph). | |||
There was a problem hiding this comment.
This link gets redirected to Track 2 quick start, so re-worded the entire intro to refer to the link as T2 and not T1
| * [.NET Core Visual Studio 2015 or 2017 tools](http://www.microsoft.com/net/core). | ||
| * An Azure subscription. | ||
| * [An event hub namespace and an event hub](event-hubs-quickstart-namespace-portal.md). | ||
| * An Azure Storage account. |
There was a problem hiding this comment.
This must be a formatter on my editor
| @@ -1,16 +1,15 @@ | |||
| # Send events to Azure Event Hubs in .NET Standard | |||
|
|
|||
| This sample shows how to write a .NET Core console application that sends a set of events to an Event Hub. You can run the solution as-is, replacing the `EhConnectionString` and `EhEntityPath` strings with your Event Hub values. The sample is also [available as a tutorial](https://docs.microsoft.com/azure/event-hubs/event-hubs-dotnet-standard-getstarted-send). | |||
There was a problem hiding this comment.
This link gets redirected to Track 2 quick start, so re-worded the entire intro to refer to the link as T2 and not T1
| ## Run the sample | ||
|
|
||
| **Note:** This sample uses the legacy Event Hubs library `Microsoft.Azure.EventHubs`. We strongly recommend you to use the current library `Azure.Messaging.EventHubs`. | ||
| ## Prerequisites |
There was a problem hiding this comment.
I moved around the code here because the custom role set up instructions applies to both T1 and T2.
The first 3 commits in this PR are to address particular files being touched in #474