-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] az functionapp/logicapp create
: Add new --https-only
parameter
#23213
Changes from 14 commits
a44b7a7
b93efd7
e22bed8
edb9dac
3f2d96d
230fbba
ef73111
ae66a01
e3df608
a400b0f
fe2366c
0ba0123
8b219d7
1c1a551
6c4129e
a6e5472
95d0b3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -336,7 +336,7 @@ def validate_vnet_integration(cmd, namespace): | |
resource_group_name=namespace.resource_group_name) | ||
|
||
sku_name = plan_info.sku.name | ||
disallowed_skus = {'FREE', 'SHARED', 'BASIC', 'ElasticPremium', 'PremiumContainer', 'Isolated', 'IsolatedV2'} | ||
disallowed_skus = {'FREE', 'SHARED', 'PremiumContainer', 'Isolated', 'IsolatedV2'} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we confirm with function apps team this list accurate? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We confirmed this on the original email thread with the functions team that prompted this change |
||
if get_sku_tier(sku_name) in disallowed_skus: | ||
raise ArgumentUsageError("App Service Plan has invalid sku for vnet integration: {}." | ||
"Plan sku cannot be one of: {}. " | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the return_label be TRUE here - since this change will impact webapp up where we default this to True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and
return_label=True
causes broken behavior when the user calls this as--https-only false
. Havingreturn_label=True
results in the value being passed as a string (ie"true"
or"false"
) instead of a boolean value (True
orFalse
). This behavior is explained in the documentation in the screenshot below. The result is that if we hadreturn_label=True
and the user called the command with--https-only false
, they would have a webapp with httpsOnly true.I just doubled check this and it doesn't impact webapps created with
az webapp up
-- they still are httpsOnly by default:Documentation for the return_label argument: