Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Pylint} Bump Pylint to 2.8.0 #17861

Merged
merged 3 commits into from
May 7, 2021
Merged

{Pylint} Bump Pylint to 2.8.0 #17861

merged 3 commits into from
May 7, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Apr 26, 2021

Require Azure/azure-cli-dev-tools#295

Context

The old pylint 2.3.0 is

Change

  • Use the latest azdev with pylint bumped to 2.8.0
  • Disable new checkers of the new pylint

TODO

All these newly disabled checkers should be fixed one by one in their dedicated PRs:

Additional information

The list of failed checkers are acquired by running pylint with --msg-template='{symbol}':

python -m pylint d:\cli\azure-cli\src\azure-cli\azure\cli d:\cli\azure-cli\src\azure-cli-core\azure\cli\core d:\cli\azure-cli\src\azure-cli-telemetry\azure\cli\telemetry d:\cli\azure-cli\src\azure-cli-testsdk\azure\cli\testsdk d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\acr d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\acs d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\advisor d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\ams d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\apim d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\appconfig d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\appservice d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\aro d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\backup d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\batch d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\batchai d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\billing d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\botservice d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\cdn d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\cloud d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\cognitiveservices d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\config d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\configure d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\consumption d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\container d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\cosmosdb d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\databoxedge d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\deploymentmanager d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\dla d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\dls d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\dms d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\eventgrid d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\eventhubs d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\extension d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\feedback d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\find d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\hdinsight d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\interactive d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\iot d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\keyvault d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\kusto d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\lab d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\managedservices d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\maps d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\monitor d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\natgateway d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\netappfiles d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\network d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\policyinsights d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\privatedns d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\profile d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\rdbms d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\redis d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\relay d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\reservations d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\resource d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\role d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\search d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\security d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\servicebus d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\servicefabric d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\signalr d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\sql d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\sqlvm d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\storage d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\synapse d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\util d:\cli\azure-cli\src\azure-cli\azure\cli\command_modules\vm --ignore vendored_sdks,privates --rcfile=D:\cli\azure-cli\pylintrc --jobs 8 --msg-template='{symbol}'

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 26, 2021

pylint

@yonzhan yonzhan added this to the S186 milestone Apr 26, 2021
@yonzhan yonzhan requested review from kairu-ms and jsntcy April 26, 2021 03:41
# Conflicts:
#	.azure-pipelines/templates/azdev_setup.yml
@jiasli jiasli modified the milestones: S186, S187 Apr 26, 2021
@jiasli jiasli marked this pull request as ready for review May 7, 2021 05:39
@jiasli jiasli merged commit 32d2691 into Azure:dev May 7, 2021
@jiasli jiasli deleted the bump-pylint branch May 7, 2021 05:58
@jiasli jiasli changed the title {pylint} Disable more checkers to comply with pylint 2.8.0 {Pylint} Bump Pylint to 2.8.0 May 7, 2021
@jiasli jiasli mentioned this pull request Nov 4, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants