Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az deployment group create: mode is not a known attribute of class... #26112

Closed
timmkrause opened this issue Apr 11, 2023 · 9 comments
Closed

az deployment group create: mode is not a known attribute of class... #26112

timmkrause opened this issue Apr 11, 2023 · 9 comments
Assignees
@zhoxing-ms
Labels
ARM - Templates Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.
Milestone
Backlog

Comments

@timmkrause
Copy link

timmkrause commented Apr 11, 2023 •
edited
Loading

This is autogenerated. Please review and update as needed.

Describe the bug

Command Name
az deployment group create

Errors:

mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored

It breaks our pipelines. Why is a warning written to standard error?
With 2.46.0 everything was healthy.

To Reproduce:

  • az deployment group create --name "" --resource-group "" --template-spec "" --parameters ""

Expected Behavior

  • No warning should be displayed.
  • (Warnings shouldn't be written to standard error?)

Environment Summary

Windows-10-10.0.19045-SP0
Python 3.10.10
Installer: MSI

azure-cli 2.47.0

Extensions:
account 0.2.5
containerapp 0.3.27

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0
@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group labels Apr 11, 2023
@ghost ghost assigned zhoxing-ms Apr 11, 2023
@ghost ghost added this to the Backlog milestone Apr 11, 2023
@ghost ghost added Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 11, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 11, 2023

Thank you for opening this issue, we will look into it.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Apr 12, 2023 •
edited
Loading

In fact, this issue is caused by the lack of mode attribute in the TemplateLink mode from Python SDK.
The relevant code was introduced by PR #14448. code link:

azure-cli/src/azure-cli/azure/cli/command_modules/resource/custom.py

Line 964 in 85a933a

template_link = TemplateLink(id=template_spec, mode="Incremental")

Since I did not find a record of mode attribute being removed in the history notes of Python SDK, I am not sure if there was a breaking change in the Python SDK/Swagger which was not recorded in the history notes or if this was a bug with the previous code.
As template spec related code is owned by service team, + @detienne20 to help take a look at this issue

@zhoxing-ms zhoxing-ms added the Service Attention This issue is responsible by Azure service team. label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @josephkwchan, @jennyhunter-msft.

Issue Details

This is autogenerated. Please review and update as needed.

Describe the bug

Command Name
az deployment group create

Errors:

mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored

It breaks our pipelines. Why is a warning written to standard error?
With 2.46.0 everything was healthy.

To Reproduce:

  • az deployment group create --name "" --resource-group "" --template-spec "" --parameters ""

Expected Behavior

  • No warning should be displayed.
  • (Warnings shouldn't be written to standard error?)

Environment Summary

Windows-10-10.0.19045-SP0
Python 3.10.10
Installer: MSI

azure-cli 2.47.0

Extensions:
account 0.2.5
containerapp 0.3.27

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0
Author: timmkrause
Assignees: zhoxing-ms
Labels:

Service Attention, question, ARM, customer-reported, Auto-Assign, Azure CLI Team
Milestone: Backlog

@jennyhunter-msft jennyhunter-msft added ARM - Templates and removed ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group labels Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/deployments-owners.

Issue Details

This is autogenerated. Please review and update as needed.

Describe the bug

Command Name
az deployment group create

Errors:

mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored

It breaks our pipelines. Why is a warning written to standard error?
With 2.46.0 everything was healthy.

To Reproduce:

  • az deployment group create --name "" --resource-group "" --template-spec "" --parameters ""

Expected Behavior

  • No warning should be displayed.
  • (Warnings shouldn't be written to standard error?)

Environment Summary

Windows-10-10.0.19045-SP0
Python 3.10.10
Installer: MSI

azure-cli 2.47.0

Extensions:
account 0.2.5
containerapp 0.3.27

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0
Author: timmkrause
Assignees: zhoxing-ms
Labels:

Service Attention, question, ARM - Templates, customer-reported, Auto-Assign, Azure CLI Team
Milestone: Backlog

@anthony-c-martin
Copy link
Member

@zhoxing-ms I can't see any evidence of this property ever having been here - here's the TemplateLink class in the original SDK that introduced it: https://github.com/Azure/azure-sdk-for-python/blob/27e4203818e227ba2604ff52dcf55ce2293c4c37/sdk/resources/azure-mgmt-resource/azure/mgmt/resource/resources/v2020_06_01/models/_models_py3.py#L2540-L2543

@zhoxing-ms
Copy link
Contributor

@anthony-c-martin Thank you for your clarification. Since the template spec related code is owned by service team, could you please help submit a PR to remove the mode="Incremental"? @anthony-c-martin @detienne20 Then we will review and merge this PR for you, thanks~

@timmkrause
Copy link
Author

Why removing? Does this imply that something is wrong regarding mode on our side?

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Apr 17, 2023 •
edited
Loading

Why removing? Does this imply that something is wrong regarding mode on our side?

Yes, I guess this was a legacy code issue. @detienne20 please help confirm it~

@timmkrause
Copy link
Author

At a first glance we don't set any mode in that regard. Is this maybe something happening under the cover which is hidden from us?

@zhoxing-ms zhoxing-ms mentioned this issue Jul 5, 2023
Closed
@detienne20 detienne20 mentioned this issue Jul 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhoxing-ms zhoxing-ms

Labels
ARM - Templates Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@timmkrause @zhoxing-ms @jennyhunter-msft @anthony-c-martin @yonzhan