Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max surge in vmss rolling upgrade policy configurability #24846

Closed
johnzhang-microsoft opened this issue Dec 9, 2022 · 4 comments · Fixed by #25333
Closed

Add max surge in vmss rolling upgrade policy configurability #24846

johnzhang-microsoft opened this issue Dec 9, 2022 · 4 comments · Fixed by #25333
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request

Comments

@johnzhang-microsoft
Copy link
Member

Related command

az vmss create --maxsurge

https://learn.microsoft.com/en-us/cli/azure/vmss?view=azure-cli-latest#az-vmss-create

Resource Provider

CRP, Microsoft.Compute

Description of Feature or Work Requested

Users will set enable to true for max surge. If enabled, VMSS will create new virtual machines to upgrade the scale set, rather than updating the existing virtual machines. Existing virtual machines will be deleted once the new virtual machines are created for each batch.

Minimum API Version Required

2022-11-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#21253
Azure/azure-sdk-for-net#32880

Request Example

Not merged into master branch yet. This is where it will eventually be though, you can replace commit hash with "master":

https://github.com/Azure/azure-rest-api-specs/blob/f0900e97e33c476881e6e54de58f19293c96c56a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-11-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSets_Update_MaximumSet_Gen.json

https://github.com/Azure/azure-rest-api-specs/blob/f0900e97e33c476881e6e54de58f19293c96c56a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-11-01/virtualMachineScaleSet.json

See usage of "maxSurge"

Target Date

CLI team's planned 02/07/2023 release window should be okay

Additional context

No response

@ghost ghost added the Compute az vm/vmss/image/disk/snapshot label Dec 9, 2022
@ghost ghost added this to the Backlog milestone Dec 9, 2022
@ghost ghost assigned zhoxing-ms Dec 9, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 9, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 9, 2022

compute feature

@yonzhan yonzhan added the Azure CLI Team The command of the issue is owned by Azure CLI team label Dec 9, 2022
@yonzhan yonzhan modified the milestones: Backlog, Jan 2023 (2023-02-07) Dec 9, 2022
@Jing-song
Copy link
Contributor

Hi @johnzhang-microsoft I can't find maxSurge in the python SDK here(Azure/azure-rest-api-specs#21253 (comment)), 2022-11-01 folder does not exist, could you please provide a private package containing maxSurge for me to develop. And azure cli requires publish SDK, so please release it on pypi as soon as possible.

@johnzhang-microsoft
Copy link
Member Author

Hi @PARADISSEEKR . There were holidays in the USA, so the 2022-11-01 API release master needed to wait. He just submitted SDK generation for 2022-11-01 for python today. Should be available by end of this week or beginning of next week. Will that work?

@mimckitt
Copy link
Contributor

Checking in on the status of this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment