Missing dependency of msrestazure from azure-cli-core

[irvokopo]

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

Is there a missing dependency?

To Reproduce

In this code CLoudError is imported from msrestazure: https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/commands/validators.py#:~:text=from%20msrestazure.azure_exceptions%20import%20CloudError

Expected behavior

Should the 'msrestazure' package be listed as a dependency here: https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/setup.py#:~:text=%5D-,DEPENDENCIES%20%3D%20%5B,%5D,-%23%20dependencies%20for%20specific

Environment summary

Additional context

[jiasli]

@zhoxing-ms, is this line still valid after we migrate to Track 2 for azure-mgmt-resource?

azure-cli/src/azure-cli-core/azure/cli/core/commands/validators.py

Line 74 in e3fb824

from msrestazure.azure_exceptions import CloudError

[zhoxing-ms]

Good catch! I have submitted a PR #20739 to fix this issue

[irvokopo]

Hello,
Thank you very much for this!
Would it, maybe make sense to tackle similar usage of CloudError elsewhere as well, for e.g.:
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/util.py#:~:text=exceptions%20import%20JMESPathError-,from%20msrestazure.azure_exceptions%20import%20CloudError,-from%20msrest.exceptions

Thank you again!

[jiasli]

Actually we can't, as some SDKs are still on Track 1. Azure CLI needs to catch those CloudError so that Track 1 SDKs' exceptions can be correctly handled.

[irvokopo]

I see - thank you again for addressing the issue getting back to me - happy to have this closed : )

[irvokopo]

P.S.: Just to mention, I've had one other missing-dependency issue of 'packaging', from here:
https://github.com/Azure/azure-cli/blob/d52397ab0f9e80c1f5e68e200ae66b6a272da0ac/src/azure-cli-core/azure/cli/core/__init__.py#:~:text=from%20packaging.version%20import%20parse

[jiasli]

Ah, nice finding. I actually just bumped packaging recently: #20661

Just wondering how you are able to find those missing dependencies? 😸