Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlatformImageFeatures to VMImage object in PIR Consumption GET API #16863

Closed
grace-liang opened this issue Feb 9, 2021 · 7 comments
Closed
Assignees
Milestone

Comments

@grace-liang
Copy link

Resource Provider
Azure.Compute

Description of Feature or Work Requested

GET Consumption API docs: https://docs.microsoft.com/en-us/cli/azure/vm/image?view=azure-cli-latest#az_vm_image_show

Sample command:
grace@Azure:~$ az vm image show --location EastUS2EUAP --publisher RedHat --offer RHEL --sku 8_3 --version 8.3.2020111905

Sample current payload:
{ "automaticOsUpgradeProperties": { "automaticOsUpgradeSupported": false }, "dataDiskImages": [], "disallowed": { "vmDiskType": "None" }, "hyperVGeneration": "V1", "id": "/Subscriptions/97f78232-382b-46a7-8a72-964d692c4f3f/Providers/Microsoft.Compute/Locations/EastUS2EUAP/Publishers/RedHat/ArtifactTypes/VMImage/Offers/RHEL/Skus/8_3/Versions/8.3.2020111905", "location": "EastUS2EUAP", "name": "8.3.2020111905", "osDiskImage": { "operatingSystem": "Linux", "sizeInBytes": 68719477248, "sizeInGb": 64 }, "plan": null, "tags": null }

Work requested:
An optional list of objects named features can be returned, but can also be null or empty. The features array contains an arbitrary number of PlatformImageFeature objects with fields name and value which contains arbitrary string values.

public class PlatformImageFeature { public String name; public String value; }

Example:
"features": [ { "name": "SecurityType", "value": "TrustedLaunchSupported" }, { "name": "IsHibernateSupported", "value": "True" } ],

Note: please do testing in canary regions- this array will not be returned in public regions until post public preview announcement.

Minimum API Version Required
Any. Work is not versioned.

Swagger Link
Swagger: Azure/azure-rest-api-specs#12085

  • currently checked in to compute-2020-12 branch, which will be merged with master shortly, if it hasn't already.

Target Date
Feb 26, 2021

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 9, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 9, 2021
@yungezz
Copy link
Member

yungezz commented Feb 9, 2021

Swagger not in master yet.

@grace-liang
Copy link
Author

Closing this request for now, please disregard. Will revisit soon.

@grace-liang
Copy link
Author

Reopening. Swagger was merged to master in this PR: Azure/azure-rest-api-specs#12334
@qwordy please have a look when you get a chance.

@grace-liang grace-liang reopened this Feb 17, 2021
@qwordy qwordy added this to the S185 milestone Feb 20, 2021
@qwordy
Copy link
Member

qwordy commented Feb 20, 2021

OK

@qwordy
Copy link
Member

qwordy commented Mar 4, 2021

@grace-liang It is supported now.
When I run

az vm image show --location EastUS2EUAP --publisher RedHat --offer RHEL --sku 8_3 --version 8.3.2020111905

I get

"features": null

Can you give a image that has features?

@qwordy qwordy modified the milestones: S185, S184 Mar 4, 2021
@grace-liang
Copy link
Author

Sorry about that @qwordy.

Please use
az vm image show --location EastUS2EUAP --publisher RedHat --offer RHEL --sku 83-gen2 --version 8.3.2020111907

which should return
"features": [ { "name": "SecurityType", "value": "TrustedLaunchSupported" } ],

@qwordy
Copy link
Member

qwordy commented Mar 8, 2021

Thanks, @grace-liang. I test it in Azure CLI 2.20.0. It works as expected. Close this issue now.

@qwordy qwordy closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants