Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should capture bug that a folder don't have __init__.py but want to include it as a Python package #1608

Closed
haroldrandom opened this issue Apr 27, 2020 · 2 comments
Closed

CI should capture bug that a folder don't have __init__.py but want to include it as a Python package #1608

haroldrandom opened this issue Apr 27, 2020 · 2 comments
Assignees
@haroldrandom
Labels
CI feature-request This issue requires a new behavior in the product in order be resolved. OKR3.2 Candidate
Milestone
S171

Comments

@haroldrandom
Copy link
Contributor

haroldrandom commented Apr 27, 2020 •
edited
Loading

Extension name (the extension in question)

portal

Description of issue (in as much detail as possible)

If a folder don't have a __init__.py and use find_packages() in setup.py, then the build tool won't regard it as a valid Python Package, the the built wheel won't pack it into the wheel file.

For example this warning from Azure/azure-cli PR stage:
image
it's caused by the portal extension which doesn't have a __init__.py under src/portal/azext_portal/generated/

CI should block and give warning
@haroldrandom haroldrandom self-assigned this Apr 27, 2020
@haroldrandom haroldrandom added this to the S170 milestone Apr 27, 2020
@YalinLi0312 YalinLi0312 mentioned this issue Apr 27, 2020
Merged
3 tasks
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 27, 2020

add to S170

@yonzhan yonzhan added feature-request This issue requires a new behavior in the product in order be resolved. OKR3.2 Candidate Feature Request labels May 3, 2020
@haroldrandom haroldrandom mentioned this issue May 18, 2020
Closed
@yonzhan yonzhan modified the milestones: S170, S171 May 30, 2020
@haroldrandom
Copy link
Contributor Author

Closed as plan to onboard pytest to azure-cli-extension CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haroldrandom haroldrandom

Labels
CI feature-request This issue requires a new behavior in the product in order be resolved. OKR3.2 Candidate
Projects
None yet
Milestone
S171
Development

No branches or pull requests
2 participants
@haroldrandom @yonzhan