From f5caab7a6063e94971b4a7ff0f08a94730ed605a Mon Sep 17 00:00:00 2001 From: ZelinWang Date: Tue, 10 Oct 2023 11:14:39 +0800 Subject: [PATCH] {CI} Add new comment to explain the reason that pin the wheel to 0.30.0 (#6842) * Update test_index.py * Update pull_request_template.md --- .github/pull_request_template.md | 2 +- scripts/ci/test_index.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b745d54e274..c947de5815a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,7 +9,7 @@ This checklist is used to make sure that common guidelines for a pull request ar ### General Guidelines - [ ] Have you run `azdev style ` locally? (`pip install azdev` required) -- [ ] Have you run `python scripts/ci/test_index.py -q` locally? +- [ ] Have you run `python scripts/ci/test_index.py -q` locally? (`pip install wheel==0.30.0` required) For new extensions: diff --git a/scripts/ci/test_index.py b/scripts/ci/test_index.py index c7e3d1a764a..093ebaa7388 100755 --- a/scripts/ci/test_index.py +++ b/scripts/ci/test_index.py @@ -85,6 +85,8 @@ def test_extension_filenames(self): "Extension name mismatch in extensions['{}']. " "Found an extension in the list with name " "{}".format(ext_name, item['metadata']['name'])) + # Due to https://github.com/pypa/wheel/issues/235 we prevent whls built with 0.31.0 or greater. + # 0.29.0, 0.30.0 are the two previous versions before that release. parsed_filename = WHEEL_INFO_RE(item['filename']) p = parsed_filename.groupdict() self.assertTrue(p.get('name'), "Can't get name for {}".format(item['filename']))