Skip to content
This repository was archived by the owner on Feb 3, 2021. It is now read-only.

Remove custom scripts from repo #441

Closed
jafreck opened this issue Mar 15, 2018 · 3 comments · Fixed by #517
Closed

Remove custom scripts from repo #441

jafreck opened this issue Mar 15, 2018 · 3 comments · Fixed by #517
Assignees
Labels
Milestone

Comments

@jafreck
Copy link
Member

jafreck commented Mar 15, 2018

Originally kept to maintain backwards compatibility, however, to access the services the custom scripts are running, the ports need to be open. Since the plugin PR, ports are no longer opened by default, so custom scripts don't work. They should be removed.

@jafreck jafreck added the bug label Mar 15, 2018
@jafreck jafreck added this to the v0.7.0 milestone Mar 15, 2018
@timotheeguerin
Copy link
Member

Well they still work but you need to open the port yourself

@jafreck
Copy link
Member Author

jafreck commented Mar 15, 2018

they only work if you ssh outside of aztk, which effectively means they are broken.

This is what is causing the confusion in #434. It would probably be best to fail for people using custom scripts rather than allow them to create a cluster but not access into a service unless they manually ssh in to the cluster & port forward.

@timotheeguerin
Copy link
Member

timotheeguerin commented Mar 15, 2018

oh I thought you could still open custom ports when ssh with aztk but apparently not

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants