Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializer didn't handle non-success responses in Modular MPG #2937

Open
MaryGao opened this issue Dec 5, 2024 · 1 comment
Open

Deserializer didn't handle non-success responses in Modular MPG #2937

MaryGao opened this issue Dec 5, 2024 · 1 comment

Comments

@MaryGao
Copy link
Member

MaryGao commented Dec 5, 2024

This is similar to unbranded one, but we would focus on the Azure scope because this behavior introduced breakings between HLC and Modular.

In Modular we only deserialize the success responses and for other responses we would throw as general RestError. So that we temporality ignore the error model generation here.

export async function _getApplicationDeserialize(
  result: PathUncheckedResponse,
): Promise<BatchApplication> {
  const expectedStatuses = ["200"];
  if (!expectedStatuses.includes(result.status)) {
    throw createRestError(result);
  }

  return batchApplicationDeserializer(result.body);
}

But in HLC if default responses or non-success responses are specified we would deserialize to correct response models(see client and core code).

In this issue we need to decide if we would accept this breaking or handle these non-success responses for Azure SDK.

@MaryGao MaryGao changed the title Deserializer didn't handle non-success responses in Modular in MPG Deserializer didn't handle non-success responses in Modular MPG Dec 5, 2024
@qiaozha qiaozha added p0 priority 0 blocked labels Dec 11, 2024
@qiaozha
Copy link
Member

qiaozha commented Dec 11, 2024

Also blocked by #2943

@qiaozha qiaozha added 1_0_E2E P1 priority 1 and removed p0 priority 0 labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants