Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen] Test folder generation Improvements - env file #2128

Closed
Tracked by #2126
HarshaNalluru opened this issue Nov 17, 2023 · 1 comment
Closed
Tracked by #2126

[Codegen] Test folder generation Improvements - env file #2128

HarshaNalluru opened this issue Nov 17, 2023 · 1 comment
Assignees
@qiaozha
Labels
P2 priority 2 RLC

Comments

@HarshaNalluru
Copy link
Member

Get rid of

  • test/env.ts
  • test/env.browser.ts
  • Also the related browser mapping in "package.json"

Instead import { env } from "@azure-tools/test-recorder" package as the recorder does that already for you without any additional code.
@HarshaNalluru HarshaNalluru mentioned this issue Nov 17, 2023
Open
@qiaozha qiaozha self-assigned this Nov 22, 2023
@qiaozha qiaozha added P2 priority 2 RLC labels Nov 22, 2023
@MaryGao
Copy link
Member

MaryGao commented Jul 25, 2024

Closed as this is resolved in latest codegen.

@MaryGao MaryGao closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

Labels
P2 priority 2 RLC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaryGao @HarshaNalluru @qiaozha