Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not extend scope, but replace it #743

Closed
lmazuel opened this issue Aug 7, 2020 · 0 comments
Closed

Do not extend scope, but replace it #743

lmazuel opened this issue Aug 7, 2020 · 0 comments
Assignees
@iscai-msft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. p0

Comments

@lmazuel
Copy link
Member

lmazuel commented Aug 7, 2020 

 self.credential_scopes = ['https://management.azure.com/.default'] 
 self.credential_scopes.extend(kwargs.pop('credential_scopes', []))

should be:

self.credential_scopes = kwargs.pop('credential_scopes', ['https://management.azure.com/.default'])

See Azure/azure-sdk-for-python#12947 for details
@lmazuel lmazuel added bug This issue requires a change to an existing behavior in the product in order to be resolved. Autorest v3 refactoring p0 labels Aug 7, 2020
@iscai-msft iscai-msft mentioned this issue Aug 7, 2020
Merged
@lmazuel lmazuel closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iscai-msft iscai-msft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmazuel @iscai-msft