Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter should not use TSX to run installation script #2904

Closed
lmazuel opened this issue Nov 6, 2024 · 2 comments
Closed

Emitter should not use TSX to run installation script #2904

lmazuel opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels

Comments

@lmazuel
Copy link
Member

lmazuel commented Nov 6, 2024

We need emitters to have as low dependencies as possible, and "tsx" is convenient, but not necessary. We could write our scripts in TypeScript, compile them in JS at release time, and ship that (not sure the details, I'm sure a JS expert could provide help). But we shouldn't rely on "typescript" being installed. It ends up like this for 3P people:

Image

@msyyc msyyc self-assigned this Nov 11, 2024
@msyyc msyyc added the p1 label Nov 12, 2024
@msyyc
Copy link
Member

msyyc commented Nov 12, 2024

After discussion, we will remove dependency for tsx.

@iscai-msft
Copy link
Contributor

closing for now, since this makes code much more complicated. we will have to rewrite our installation scripts in js, and I think it's not worth it considering it's industry standard to use tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants