-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate patch files if a patch file doesn't already exist #1036
Comments
I would suggest by default this file has no executable code, some documentation about what this file is about, and some example of commented code that you could just uncomment to start with the patch Example # This file is a patch file that allows to manually update the generated code behavior. Changes in this file will NOT be overwritten and will be kept from generation to generation
# yadayadayada more yadayadayada
#
# Uncomment this code for a patch_sdk
# def patch_sdk():
# """Use this code to change something."""
# import this
# this.something = True
#
# class BasicOporationCustomization:
# def something() |
I think we may not need to add |
hey @msyyc our goal is to encourage SDK developers to use the We're thinking the minimum this file should have (just to start off) is
Then, we can add to this file with good documentation examples, i.e. "How do I handwrite overload code?", but that can be saved for later |
Hi @iscai-msft, got it and I will do it asap. |
Since we're leaning more into encouraging people to use the patch.py to modify the generated code, we want to make it easier for people to start customizing the generated code. This will also clean up a little bit of our generated code, because we can assume that a patch.py file exists. If a patch.py file already exists, we don't do anything and keep the code the same. However, if there is no patch.py file in the generated output folder, we want to create a patch.py file (for both sync and async). This patch.py file should also have basic instructions on how to write to this patch.py file, so users have an idea when they first start out about what to do
The text was updated successfully, but these errors were encountered: