Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Set the csi-secrets-store to have a priority class #3909

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Set the csi-secrets-store to have a priority class #3909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e042fde
Set the csi-secrets-store to have a priority class
Michael-Sinz Oct 8, 2020
b8577f6
Change comments
Michael-Sinz Oct 8, 2020
3d1424d
make generate
Michael-Sinz Oct 8, 2020
486a2ff
Fix up template comments
Michael-Sinz Oct 8, 2020
eeebcaa
add addonmanager label
jackfrancis Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions parts/k8s/addons/secrets-store-csi-driver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,20 @@ status:
conditions: []
storedVersions: []
---
{{- /* A priority class for the daemonset such that they are not */}}
{{- /* frozen out of a node due to the node filling up with "normal" */}}
{{- /* pods before the daemonset controller can get the daemonset */}}
{{- /* pods to be scheduled. */}}
apiVersion: scheduling.k8s.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @aramase @chewong this change was made due to observed scheduling contention on clusters at scale (i.e., nodes coming on line but filling up so quickly that csi-secrets-store pods were not able to be scheduled via daemonset

Should we make such a change to the upstream reference specs as well?

kind: PriorityClass
metadata:
name: csi-secrets-store
labels:
addonmanager.kubernetes.io/mode: EnsureExists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this label so that kube-addon-manager would interpret this resource for loading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - sorry I missed that.

value: 1000
globalDefault: false
description: "This is the daemonset priority class for csi-secrets-store"
---
kind: DaemonSet
apiVersion: apps/v1
metadata:
Expand All @@ -298,6 +312,7 @@ spec:
labels:
app: csi-secrets-store
spec:
priorityClassName: csi-secrets-store
serviceAccountName: secrets-store-csi-driver
hostNetwork: true
containers:
Expand Down Expand Up @@ -458,6 +473,7 @@ spec:
labels:
app: csi-secrets-store-provider-azure
spec:
priorityClassName: csi-secrets-store
serviceAccountName: csi-secrets-store-provider-azure
hostNetwork: true
containers:
Expand Down
16 changes: 16 additions & 0 deletions pkg/engine/templates_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.