This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: update sgx doc and sgx-test tag #3349
docs: update sgx doc and sgx-test tag #3349
Changes from 10 commits
e09b80b
acbd680
e59ce3d
18dd3eb
2a07d17
9015398
5dbb8a7
e08f8c2
9db7f97
a3e892f
bfd3ba2
218dc91
ae362bd
ff87f08
c4e1a26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I assume this image has the equivalent "run something to validate basic SGX functionality and exit 0 if success" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! It has the same helloworld application, just moved the executing command to the image itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running tests to validate this now, then will merge, thanks!
Btw, do we know why we are only testing Kubernetes v1.15 and v1.16? Does the
sgx-device-plugin
not work w/ v1.17+ for some reason (that would be weird), or do we need to enable tests for those versions of Kubernetes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where exactly is this test happening? There's a different version of the yaml file for k8s v1.17 onwards because of changes from beta mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use this config as input to the Jenkinsfile in the root of the project:
https://github.com/Azure/aks-engine/blob/master/test/e2e/test_cluster_configs/sgx.json
Essentially, by building an 18.04-LTS node pool w/ the
Standard_DC2s
VM SKU, we expect that the drivers will be installed and that thissgx-test.yaml
will be properly scheduled and executed on a node in the cluster.I'm building a 1.18 cluster now /w a 18.04 +
Standard_DC2s
node pool, I'll report back...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sgx-test.yml mounts /dev/sgx so it essentially doesn't depend on the plugin...