Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: simplify golangci-lint invocation #3182

Merged
merged 1 commit into from
May 4, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented May 2, 2020

Reason for Change:
This shell hackery is no longer necessary now that golangci/golangci-lint#276 is fixed.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #3182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3182   +/-   ##
=======================================
  Coverage   71.24%   71.24%           
=======================================
  Files         147      147           
  Lines       25753    25753           
=======================================
  Hits        18348    18348           
  Misses       6268     6268           
  Partials     1137     1137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c1c78...c827972. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 4, 2020
@jackfrancis jackfrancis merged commit 25145d2 into Azure:master May 4, 2020
@acs-bot
Copy link

acs-bot commented May 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the simpler-linter-call branch May 4, 2020 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants