This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: use full userAssignedID reference in ARM template #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidParks8
previously approved these changes
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #3116 +/- ##
=======================================
Coverage 71.03% 71.03%
=======================================
Files 147 147
Lines 25553 25553
=======================================
Hits 18152 18152
Misses 6271 6271
Partials 1130 1130
Continue to review full report at Codecov.
|
DavidParks8
approved these changes
Apr 21, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 15, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 15, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 15, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
xuto2
pushed a commit
that referenced
this pull request
May 16, 2020
* fix: Expose error details in Windows CSE (#3159) * feat: Updating Windows VHDs to include May patches (#3263) * fix: the os disk size restriction is changed in azure. (#3043) * refactor: Create signable PS scripts (#3015) * feat: Refactor PS scripts to be static * fix: use full userAssignedID reference in ARM template (#3116) * fix: don't hardcode pause image for containerD on Windows (#3158) * chore: update Windows pause image (#3210) * fix: USER_ASSIGNED_IDENTITY_ID is empty in azure.json (#3254) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Liming Liu <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]> Co-authored-by: Jack Francis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR uses the fully qualified
reference(variables('userAssignedIDReference'), variables('apiVersionManagedIdentity')).clientIdin the CSE string concatenation, so that in the event that the same string value is used by another resource, it can be properly distinguished during ARM template interpretation.Issue Fixed:
Fixes #3114
Requirements:
Notes: