This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: Create signable PS scripts #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksubrmnn
commented
Apr 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
==========================================
- Coverage 70.63% 70.56% -0.07%
==========================================
Files 145 145
Lines 25151 25189 +38
==========================================
+ Hits 17765 17775 +10
- Misses 6283 6309 +26
- Partials 1103 1105 +2
Continue to review full report at Codecov.
|
ksubrmnn
force-pushed
the
refactor
branch
2 times, most recently
from
6e8a6aa to
cdf6239
Compare
marosset
reviewed
Apr 9, 2020
marosset
reviewed
Apr 15, 2020
|
/lgtm |
marosset
changed the title
marosset
approved these changes
Apr 17, 2020
alexeldeib
pushed a commit
to alexeldeib/aks-engine
that referenced
this pull request
Apr 21, 2020
* feat: Refactor PS scripts to be static
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 15, 2020
* feat: Refactor PS scripts to be static
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 15, 2020
* feat: Refactor PS scripts to be static
4 tasks
andyliuliming
added a commit
that referenced
this pull request
May 15, 2020
* build: fetch k8s Windows .zip from kubernetesartifacts storage (#2655) * build: fetch k8s Windows .zip from kubernetesartifacts storage * docs: remove build-windows-k8s * build: remove unsupported v1.15.5 from Windows VHD * fix: generate windows .zip URL correctly for download * test: update UT expectations for windowszip * fix: Expose error details in Windows CSE (#3159) * feat: Updating Windows VHDs to include May patches (#3263) * chore: update zip name for mooncake mirror (#3237) * chore: SinglePlacementGroup=false if VMSS + SLB (#3054) * fix: the os disk size restriction is changed in azure. (#3043) * refactor: Create signable PS scripts (#3015) * feat: Refactor PS scripts to be static * fix: don't hardcode pause image for containerD on Windows (#3158) * chore: update Windows pause image (#3210) * fix: USER_ASSIGNED_IDENTITY_ID is empty in azure.json (#3254) Co-authored-by: Matt Boersma <[email protected]> Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: tamilmani1989 <[email protected]> Co-authored-by: Jack Francis <[email protected]> Co-authored-by: Liming Liu <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
4 tasks
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
* feat: Refactor PS scripts to be static
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
* feat: Refactor PS scripts to be static
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
May 16, 2020
* feat: Refactor PS scripts to be static
xuto2
pushed a commit
that referenced
this pull request
May 16, 2020
* fix: Expose error details in Windows CSE (#3159) * feat: Updating Windows VHDs to include May patches (#3263) * fix: the os disk size restriction is changed in azure. (#3043) * refactor: Create signable PS scripts (#3015) * feat: Refactor PS scripts to be static * fix: use full userAssignedID reference in ARM template (#3116) * fix: don't hardcode pause image for containerD on Windows (#3158) * chore: update Windows pause image (#3210) * fix: USER_ASSIGNED_IDENTITY_ID is empty in azure.json (#3254) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Liming Liu <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]> Co-authored-by: Jack Francis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: