This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 141 141
Lines 26257 26257
=======================================
Hits 18937 18937
Misses 6227 6227
Partials 1093 1093
Continue to review full report at Codecov.
|
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
Apr 5, 2020
(cherry picked from commit 509bc9c)
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
Apr 5, 2020
(cherry picked from commit 509bc9c)
xuto2
pushed a commit
that referenced
this pull request
Apr 6, 2020
(cherry picked from commit 509bc9c) Co-authored-by: Sertaç Özercan <[email protected]>
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
Apr 16, 2020
(cherry picked from commit 509bc9c)
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
Apr 16, 2020
(cherry picked from commit 509bc9c)
xuto2
pushed a commit
that referenced
this pull request
Apr 22, 2020
…3076) * test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Matt Boersma <[email protected]> Co-authored-by: Anish Ramasekar <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
Apr 26, 2020
(cherry picked from commit 509bc9c)
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
May 5, 2020
(cherry picked from commit 509bc9c)
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
May 5, 2020
(cherry picked from commit 509bc9c)
bowen5
pushed a commit
to bowen5/aks-engine
that referenced
this pull request
May 5, 2020
(cherry picked from commit 509bc9c)
xuto2
pushed a commit
that referenced
this pull request
May 5, 2020
…18.2 (#3194) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) * feat: add support for Kubernetes 1.18.2 (#3089) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1181 (cherry picked from commit 8ebece1) * Revert "Revert windowszip path" This reverts commit 8db438e. * Update KubeBinariesSASURLBase to new path. Co-authored-by: Anish Ramasekar <[email protected]> Co-authored-by: Matt Boersma <[email protected]> Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Tried the steps in #2824 (comment) but looks like
make build
is still broken with go 1.14Had the following error when executing
go generate -mod=vendor -v ./...
Ran
make vendor
andmake build
successfully (also tried with go 1.13)Issue Fixed:
#2812
Requirements:
Notes: