This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: Updated sgx driver download urls. Fixes issue 2743 #2807
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| { | ||
| "env": { | ||
| "REGION_OPTIONS": "westeurope", | ||
| "GINKGO_SKIP": "should have healthy time synchronization|should create a pv by deploying a pod that consumes a pvc" | ||
| }, | ||
| "options": { | ||
| "allowedOrchestratorVersions": [ | ||
| "1.13", | ||
|
There was a problem hiding this comment. We're not testing Kubernetes 1.13 as of #2749. |
||
| "1.14", | ||
| "1.15", | ||
| "1.16" | ||
| ] | ||
| }, | ||
| "apiModel": { | ||
| "apiVersion": "vlabs", | ||
| "properties": { | ||
| "orchestratorProfile": { | ||
| "orchestratorType": "Kubernetes" | ||
| }, | ||
| "masterProfile": { | ||
| "count": 1, | ||
| "vmSize": "Standard_D2s_v3", | ||
| "dnsPrefix": "" | ||
| }, | ||
| "agentPoolProfiles": [ | ||
| { | ||
| "name": "agentpool", | ||
| "count": 1, | ||
| "availabilityProfile": "VirtualMachineScaleSets", | ||
| "distro": "aks-ubuntu-18.04", | ||
| "vmSize": "Standard_DC2s", | ||
| "storageProfile": "ManagedDisks" | ||
| } | ||
| ], | ||
| "linuxProfile": { | ||
| "adminUsername": "azureuser", | ||
| "ssh": { | ||
| "publicKeys": [ | ||
| { | ||
| "keyData": "" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "servicePrincipalProfile": { | ||
| "clientId": "", | ||
| "secret": "" | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this URL going to break when there's a new
sgx_linuxdriver release? I'm guessing from the contents of https://download.01.org/intel-sgx/latest/dcap-latest/linux/distro/ubuntuServer18.04/ that the 1.22 release (for example) would replace this one, which would break our CSE.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mboersma you are assuming based on the presence of a single versioned artifact in that directory that only one at a time ever lives there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakman2020 can you confirm whether or not this URL will be resilient when the next version drops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that SGX drivers installation is currently broken we'll merge this as-is, with the understanding that it may break again in the future