fix: Updated sgx driver download urls. Fixes issue 2743 #2807
Conversation
|
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
yakman2020
changed the title
yakman2020
force-pushed
the
brcampbe/update-sgx-url
branch
from
6475526 to
0e489e5
Compare
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 72.35% 72.44% +0.09%
==========================================
Files 137 140 +3
Lines 25339 25562 +223
==========================================
+ Hits 18333 18518 +185
- Misses 5949 5976 +27
- Partials 1057 1068 +11 |
| @@ -125,10 +125,10 @@ installSGXDrivers() { | |||
| VERSION=$(grep DISTRIB_RELEASE /etc/*-release| cut -f 2 -d "=") | |||
| case $VERSION in | |||
| "18.04") | |||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/dcap-1.2/linux/dcap_installers/ubuntuServer18.04/sgx_linux_x64_driver_1.12_c110012.bin" | |||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/latest/dcap-latest/linux/distro/ubuntuServer18.04/sgx_linux_x64_driver_1.21.bin" | |||
There was a problem hiding this comment.
Is this URL going to break when there's a new sgx_linux driver release? I'm guessing from the contents of https://download.01.org/intel-sgx/latest/dcap-latest/linux/distro/ubuntuServer18.04/ that the 1.22 release (for example) would replace this one, which would break our CSE.
There was a problem hiding this comment.
@mboersma you are assuming based on the presence of a single versioned artifact in that directory that only one at a time ever lives there?
There was a problem hiding this comment.
Yes, although I could be wrong.
There was a problem hiding this comment.
@yakman2020 can you confirm whether or not this URL will be resilient when the next version drops?
There was a problem hiding this comment.
Given that SGX drivers installation is currently broken we'll merge this as-is, with the understanding that it may break again in the future
| ;; | ||
| "16.04") | ||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/dcap-1.2/linux/dcap_installers/ubuntuServer16.04/sgx_linux_x64_driver_1.12_c110012.bin" | ||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/latest/dcap-latest/linux/distro/ubuntuServer18.04/sgx_linux_x64_driver_1.21.bin" |
There was a problem hiding this comment.
This should refer to the Ubuntu 16.04 package, not 18.04.
| ;; | ||
| "16.04") | ||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/dcap-1.2/linux/dcap_installers/ubuntuServer16.04/sgx_linux_x64_driver_1.12_c110012.bin" | ||
| SGX_DRIVER_URL="https://download.01.org/intel-sgx/latest/dcap-latest/linux/distro/ubuntuServer18.04/sgx_linux_x64_driver_1.21.bin" |
There was a problem hiding this comment.
Same as above--shouldn't this point to the 16.04 package?
| }, | ||
| "options": { | ||
| "allowedOrchestratorVersions": [ | ||
| "1.13", |
There was a problem hiding this comment.
We're not testing Kubernetes 1.13 as of #2749.
yakman2020
force-pushed
the
brcampbe/update-sgx-url
branch
from
0e489e5 to
460a432
Compare
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Reason for Change:
Update sgx driver download urls
Issue Fixed:
Fixes #2743