This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: use IsVMSSToBeUpgraded func to validate vmss pools in upgrade #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2650 +/- ##
==========================================
+ Coverage 71.76% 71.79% +0.02%
==========================================
Files 134 134
Lines 25001 25024 +23
==========================================
+ Hits 17943 17965 +22
- Misses 6008 6009 +1
Partials 1050 1050 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR evolves the CLI upgrade functionality so that we include a
IsVMSSToBeUpgradedmethod spec to theUpgradeClusterstruct object. This method spec will ensure that the upgrade operationa is able to determine at runtime whether or not a VMSS present in the cluster resource group is actually a VMSS that correlates with anAgentPoolProfileof type"VirtualMachineScaleSets"in the cluster spec.At present (passing in no method spec), the
aks-engine upgradeoperation is subject to edge case scenarios where VMSS instances in the resource group not created byaks-engineare evaluated as Kubernetes nodes.Issue Fixed:
Requirements:
Notes: