Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Chore: updating Az CNI to v1.2.0_hotfix #4129

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Chore: updating Az CNI to v1.2.0_hotfix #4129

merged 2 commits into from
Dec 16, 2020

Conversation

vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Dec 15, 2020

Reason for Change:

Adding a critical fix to azure transparent mode CNI for mitigating intitial latency issue

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@matmerr
Copy link
Member

matmerr commented Dec 15, 2020

@sozercan
Copy link
Member

@matmer done

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #4129 (aeda2ea) into master (f279ab3) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4129      +/-   ##
==========================================
+ Coverage   73.18%   73.24%   +0.05%     
==========================================
  Files         135      135              
  Lines       20579    20632      +53     
==========================================
+ Hits        15061    15111      +50     
- Misses       4545     4547       +2     
- Partials      973      974       +1     
Impacted Files Coverage Δ
pkg/armhelpers/mockclients.go 24.16% <0.00%> (-0.06%) ⬇️
pkg/operations/kubernetesupgrade/upgrader.go 62.13% <0.00%> (-0.03%) ⬇️
pkg/api/defaults.go 93.41% <0.00%> (-0.02%) ⬇️
pkg/api/types.go 92.56% <0.00%> (ø)
pkg/api/vlabs/types.go 72.85% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <0.00%> (ø)
pkg/engine/templates_generated.go 43.70% <0.00%> (ø)
...g/operations/kubernetesupgrade/upgradeagentnode.go 52.45% <0.00%> (ø)
.../operations/kubernetesupgrade/upgrademasternode.go 42.55% <0.00%> (ø)
pkg/api/converterfromapi.go 95.66% <0.00%> (+<0.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f279ab3...aeda2ea. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Dec 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, vakalapa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit cae9e9a into Azure:master Dec 16, 2020
@marosset
Copy link
Contributor

This change broke the Windows VHD builds.
https://kubernetesartifacts.azureedge.net/azure-cni/v1.2.0/binaries/azure-vnet-cni-singletenancy-windows-amd64-v1.2.0_hotfix.zip does not resolve.
@vakalapa Please take a look.

@marosset
Copy link
Contributor

looks like that URL needs to be https://kubernetesartifacts.azureedge.net/azure-cni/v1.2.0_hotfix/binaries/azure-vnet-cni-singletenancy-windows-amd64-v1.2.0_hotfix.zip - i'll create a patch

@jackfrancis
Copy link
Member

Lemme know if a rollback of the regressing PR makes things easier (feel free to initiate that yourself as well)

@marosset
Copy link
Contributor

Lemme know if a rollback of the regressing PR makes things easier (feel free to initiate that yourself as well)

Nah, it is easy to fix.
I wonder why status didn't get reported for the Windows VHD Azure DevOps job for this PR :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants