feat: Add WinDSR support

[AbelHu]

Reason for Change:

Issue Fixed:

Fixes #4079

Credit Where Due:

Does this change contain code from or inspired by another project?

• No
• Yes

If "Yes," did you notify that project's maintainers and provide attribution?

• No
• Yes

Requirements:

• uses conventional commit messages
• [] includes documentation
• adds unit tests
• [] tested upgrade from previous version

[AbelHu]

@marosset @jsturtevant @mainred Please help to take a look at this PR. Expect your comments for the code logic. I will add unit tests and do more testing after you confirm the code logic.

[marosset]

Changes / logic look good so far.
Adding the kube-proxy flags to KubeClusterCongih is the right thing to do here.

[marosset]

Is WinOverlay something users can set in the apimodel?
If so we should add a check in validation.go and warn/fail if both WinOverlay and WinDSR are set and they are mutally exclusive.

[jsturtevant]

Doesn't look like we had the ability to add features gates to the Windows kube-proxy prior to this.

[AbelHu]

Agree with @jsturtevant, there is no other way to set feature gates to the Windows kube-proxy.

[AbelHu]

@marosset @jsturtevant @mainred I have updated the PR and it is ready for code review. Please help to take a look. Thanks.

[codecov]

Codecov Report

Merging #4104 (72e57b0) into master (2a7a029) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4104      +/-   ##
==========================================
+ Coverage   73.23%   73.26%   +0.03%     
==========================================
  Files         135      135              
  Lines       20625    20652      +27     
==========================================
+ Hits        15104    15131      +27     
  Misses       4547     4547              
  Partials      974      974              

Impacted Files	Coverage Δ
pkg/engine/templates_generated.go	43.70% <ø> (ø)
pkg/api/converterfromapi.go	95.67% <100.00%> (+0.01%)	⬆️
pkg/api/convertertoapi.go	94.02% <100.00%> (+0.02%)	⬆️
pkg/api/types.go	92.72% <100.00%> (+0.15%)	⬆️
pkg/api/vlabs/types.go	73.04% <100.00%> (+0.19%)	⬆️
pkg/engine/template_generator.go	68.01% <100.00%> (+0.45%)	⬆️
pkg/api/defaults.go	93.41% <0.00%> (-0.02%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7a029...72e57b0. Read the comment docs.

[mainred]

Do we need a doc for this, it looks good to me, but let upstream folks decide.

[AbelHu]

s, it looks good to me, but let upstream folks decide.

Thanks for reminder. I added a doc for enableWinDSR

[jsturtevant]

@AbelHu do you know if we can use DSR with azure cni or another cni other than Calico? It would be nice to run tests against this configuration while Calico support is in the works.

[AbelHu]

@AbelHu do you know if we can use DSR with azure cni or another cni other than Calico? It would be nice to run tests against this configuration while Calico support is in the works.

From my understanding, DSR is required by calico but DSR does not require Calico. I am asking the same question whether we can enable DSR by default in Windows nodes when k8s >= 1.20

Append one more information: We tested WinDSR with Calico when disabling Calico CNI.

# Set this to one of the following values:
# - "vxlan" for Calico VXLAN networking
# - "windows-bgp" for Calico BGP networking using the Windows BGP router.
# - "none" to disable the Calico CNI plugin (so that you can use another plugin).
$env:CALICO_NETWORKING_BACKEND="none"

[marosset]

/lgtm
@ksubrmnn @daschott can you help answer the above questions for DSR support?

[marosset]

Spoke with @jsturtevant and we can add testing in a later PR since we want to unblock calico support.

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[daschott]

I think we should have more end-user validation before making it default.